Skip to content

Add Cypher toStringOrNull function #2587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
colinbarry merged 3 commits into from
Jan 13, 2025
Merged

Add Cypher toStringOrNull function #2587

colinbarry merged 3 commits into from
Jan 13, 2025

Conversation

@colinbarry
Copy link
Contributor

@colinbarry colinbarry commented Jan 8, 2025 •
edited
Loading

This also refactors the existing toString function, to bring the implementation of both of these functions into accord.

@colinbarry colinbarry changed the title Add Cypher toStringOrNull function #1780 Add Cypher toStringOrNull function Jan 8, 2025
@colinbarry colinbarry force-pushed the feat/add-toStringOrNull-function branch from af76164 to 7adfc5f Compare January 8, 2025 14:00
Ignition
Ignition reviewed Jan 8, 2025
View reviewed changes
@gitbuda gitbuda linked an issue Jan 8, 2025 that may be closed by this pull request
Implement toStringOrNull function #1780
Closed
@gitbuda gitbuda added this to the mg-v3.0.0 milestone Jan 8, 2025
@gitbuda
Copy link
Member

gitbuda commented Jan 8, 2025

@colinbarry please move the info from the description (starting and including Git commit description... and below) into a comment because the whole description of a PR ends up as a git message body inside the master branch 🙏

@gitbuda gitbuda added the Docs needed Docs needed label Jan 8, 2025
@gitbuda gitbuda added the feature feature label Jan 8, 2025
@colinbarry
Copy link
Contributor Author

colinbarry commented Jan 8, 2025 •
edited
Loading

Tracking

Standard development

CI Testing Labels

  • Select the appropriate CI test labels (CI -build=build-name -test=test-suite)

Documentation checklist

  • Add the documentation label
  • Add the bug / feature label
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Add Cypher toStringOrNull function
  • [ Documentation PR link memgraph/documentation#XXXX ]
    • Is back linked to this development PR
  • [ Tag someone from docs team ]

@Ignition Ignition marked this pull request as ready for review January 8, 2025 16:49
@colinbarry colinbarry added this pull request to the merge queue Jan 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2025
@colinbarry
Add Cypher toStringOrNull function
8ce0513 
This also refactors the existing `toString` function, to bring the
implementation of both of these functions into accord.
@colinbarry
Replace qualified TypedValue::Types with using declaration
2d56060
@colinbarry
refactor: Fix clang-tidy warning about duplicated type name
7a9f547
@colinbarry colinbarry force-pushed the feat/add-toStringOrNull-function branch from 15082cc to 7a9f547 Compare January 13, 2025 11:31
@colinbarry colinbarry added this pull request to the merge queue Jan 13, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 13, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
57.7% Duplication on New Code

See analysis details on SonarQube Cloud

Merged via the queue into master with commit 03aaebb Jan 13, 2025
14 checks passed
@colinbarry colinbarry deleted the feat/add-toStringOrNull-function branch January 13, 2025 12:46
@katarinasupe katarinasupe mentioned this pull request Jan 14, 2025
Merged
11 tasks
@colinbarry colinbarry mentioned this pull request Jan 31, 2025
Open
as51340 pushed a commit that referenced this pull request Oct 24, 2025
@colinbarry
Add Cypher toStringOrNull function (#2587)
ee3ecf7 
This also refactors the existing `toString` function, to bring the
implementation of both of these functions into accord.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ignition Ignition Ignition approved these changes

Assignees

@colinbarry colinbarry

Labels

Docs needed Docs needed feature feature

Projects

None yet

Milestone

mg-v3.0.0

Development

Successfully merging this pull request may close these issues.

Implement toStringOrNull function

4 participants

@colinbarry @gitbuda @Ignition