Skip to content

Fix delta release on unique constraint error #2566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Ignition merged 3 commits into from
Jan 2, 2025
Merged

Fix delta release on unique constraint error #2566

Ignition merged 3 commits into from
Jan 2, 2025

Conversation

@Josipmrden
Copy link
Contributor

@Josipmrden Josipmrden commented Dec 20, 2024 •
edited by Ignition
Loading

Unique constraint error would release the deltas to GC as part of Abort, but not make the commit timestamp as finished. Hence the deltas and any future deltas would be prevented from being deleted during GC.

@gitbuda gitbuda requested a review from Ignition December 30, 2024 10:35
@gitbuda gitbuda added this to the mg-v3.0.0 milestone Dec 30, 2024
@gitbuda
Copy link
Member

gitbuda commented Dec 31, 2024 •
edited by Josipmrden
Loading

Standard development

CI Testing Labels

  • Select the appropriate CI test labels (CI -build=build-name -test=test-suite)

Documentation checklist

  • Add the documentation label
  • Add the bug / feature label
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Fixed bug of delta objects not releasing after unique constraint violation
  • @katarinasupe

@Ignition Ignition force-pushed the fix-delta-release-on-unique-constraint-error branch from c567c80 to d6058f6 Compare January 2, 2025 11:30
@Ignition
Better fix for Abort during Commit
b854b1b 
Need to MarkFinished the timestamp from the commit_log_
@Ignition Ignition force-pushed the fix-delta-release-on-unique-constraint-error branch from d6058f6 to b854b1b Compare January 2, 2025 11:50
@Ignition Ignition added bug bug Docs - changelog only Docs - changelog only labels Jan 2, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 2, 2025

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Josipmrden Josipmrden added CI -build=community -test=core Run community build and core tests on push CI -build=coverage -test=core Run coverage build and core tests on push CI -build=jepsen -test=core Run jepsen build and core tests on push CI -build=debug -test=core Run debug build and core tests on push CI -build=debug -test=integration Run debug build and integration tests on push CI -build=release -test=core Run release build and core tests on push CI -build=release -test=e2e Run release build and e2e tests on push CI -build=release -test=stress Run release build and stress tests on push CI -build=release -test=benchmark Run release build and benchmark on push labels Jan 2, 2025
@Josipmrden Josipmrden marked this pull request as ready for review January 2, 2025 12:23
@Ignition Ignition added this pull request to the merge queue Jan 2, 2025
Merged via the queue into master with commit 343d671 Jan 2, 2025
14 checks passed
@Ignition Ignition deleted the fix-delta-release-on-unique-constraint-error branch January 2, 2025 15:21
imilinovic pushed a commit that referenced this pull request Jan 3, 2025
@Josipmrden @Ignition @imilinovic
Fix delta release on unique constraint error (#2566)
dda17b4 
Unique constraint error would release the deltas to GC as part of Abort,
but not make the commit timestamp as finished. Hence the deltas and any
future deltas would be prevented from being deleted during GC.

---------

Co-authored-by: Gareth Lloyd <gareth.lloyd@memgraph.io>
as51340 pushed a commit that referenced this pull request Oct 24, 2025
@Josipmrden @Ignition
Fix delta release on unique constraint error (#2566)
56205b7 
Unique constraint error would release the deltas to GC as part of Abort,
but not make the commit timestamp as finished. Hence the deltas and any
future deltas would be prevented from being deleted during GC.

---------

Co-authored-by: Gareth Lloyd <gareth.lloyd@memgraph.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ignition Ignition Ignition approved these changes

Assignees

@Ignition Ignition

Labels

bug bug CI -build=community -test=core Run community build and core tests on push CI -build=coverage -test=core Run coverage build and core tests on push CI -build=debug -test=core Run debug build and core tests on push CI -build=debug -test=integration Run debug build and integration tests on push CI -build=jepsen -test=core Run jepsen build and core tests on push CI -build=release -test=benchmark Run release build and benchmark on push CI -build=release -test=core Run release build and core tests on push CI -build=release -test=e2e Run release build and e2e tests on push CI -build=release -test=stress Run release build and stress tests on push Docs - changelog only Docs - changelog only

Projects

None yet

Milestone

mg-v3.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Josipmrden @gitbuda @Ignition