Skip to content

Bugfix: Concurrent recovery and promotion crash database #2521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
as51340 merged 3 commits into from
Dec 5, 2024
Merged

Bugfix: Concurrent recovery and promotion crash database #2521

as51340 merged 3 commits into from
Dec 5, 2024

Conversation

@as51340
Copy link
Contributor

@as51340 as51340 commented Dec 5, 2024 •
edited
Loading

When replica concurrently executes recovery and promotion, WAL file can be accessed concurrently which could cause flushing a closed file. The fix contains of waiting for recovery to finish before preparing storage for new epoch.

@as51340 as51340 added bug bug Docs - changelog only Docs - changelog only labels Dec 5, 2024
@as51340 as51340 added this to the mg-v3.0.0 milestone Dec 5, 2024
@as51340 as51340 requested a review from andrejtonev December 5, 2024 09:27
@as51340 as51340 self-assigned this Dec 5, 2024
@as51340
Copy link
Contributor Author

as51340 commented Dec 5, 2024 •
edited
Loading

Tracking

Standard development

CI Testing Labels

  • Select the appropriate CI test labels (CI -build=build-name -test=test-suite)

Documentation checklist

  • Add the documentation label
  • Add the bug / feature label
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Bugfix: When recovery and promotion are executed concurrently on replica, promotion request will wait for recovery to finish before preparing storage for new epoch.
  • [ Documentation PR link memgraph/documentation#XXXX ]
    • Is back linked to this development PR
  • [ Tag someone from docs team ]

@as51340 as51340 changed the title Bugfix: Concurrent recovery and promotion crash WAL file Bugfix: Concurrent recovery and promotion crash database Dec 5, 2024
@as51340 as51340 linked an issue Dec 5, 2024 that may be closed by this pull request
Concurrent execution of promotion and recovery #2522
Closed
@as51340 as51340 force-pushed the bugfix-concurrent-recovery-and-promote branch from 29b95ab to e59d047 Compare December 5, 2024 09:34
andrejtonev
andrejtonev reviewed Dec 5, 2024
View reviewed changes
@as51340 as51340 enabled auto-merge December 5, 2024 11:35
@as51340 as51340 added this pull request to the merge queue Dec 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 5, 2024
@as51340 as51340 added this pull request to the merge queue Dec 5, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Merged via the queue into master with commit 9661a36 Dec 5, 2024
14 checks passed
@as51340 as51340 deleted the bugfix-concurrent-recovery-and-promote branch December 5, 2024 13:17
@as51340 as51340 mentioned this pull request Dec 18, 2024
Merged
11 tasks
@gitbuda gitbuda modified the milestones: mg-v3.0.0, mg-v2.22.1 Dec 22, 2024
as51340 added a commit that referenced this pull request Oct 24, 2025
@as51340
Bugfix: Concurrent recovery and promotion crash database (#2521)
3e92eb0 
When replica concurrently executes recovery and promotion, WAL file can
be accessed concurrently which could cause flushing a closed file. The
fix contains of waiting for recovery to finish before preparing storage
for new epoch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrejtonev andrejtonev andrejtonev approved these changes

Assignees

@as51340 as51340

Labels

bug bug Docs - changelog only Docs - changelog only

Projects

None yet

Milestone

mg-v2.22.1

Development

Successfully merging this pull request may close these issues.

Concurrent execution of promotion and recovery

4 participants

@as51340 @andrejtonev @gitbuda