Skip to content

Bugfix: Various issues with edge index #2390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andrejtonev merged 4 commits into from
Oct 9, 2024
Merged

Bugfix: Various issues with edge index #2390

andrejtonev merged 4 commits into from
Oct 9, 2024

Conversation

@andrejtonev
Copy link
Contributor

@andrejtonev andrejtonev commented Oct 8, 2024 •
edited
Loading

EdgeType index would assign every element as obsolete
EdgeTypeProperty index did not run GC
Allowed edge index creation even when properties on edges was false
Recovered edge indices even if properties on edges was false
EdgeType was not updated via CreateEdgeEx

@andrejtonev
Copy link
Contributor Author

andrejtonev commented Oct 8, 2024 •
edited
Loading

Tracking

Standard development

CI Testing Labels

  • Select the appropriate CI test labels (CI -build=build-name -test=test-suite)

Documentation checklist

  • Add the documentation label
  • Add the bug / feature label
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Bugfix: EdgeType index would assign every element as obsolete which would cause the index to be emptied by the GC.
      Bugfix: EdgeTypeProperty index never run its GC.
      Bugfix: Allowed edge index creation even when properties on edges was disabled. Now the user needs to use --storage-properties-on-edges
      Bugfix: Recovered edge indices even if properties on edges was disabled. Now we assert during recovery.
      Bugfix: Replication would not update edge indices
  • [ Documentation PR link memgraph/documentation#XXXX ]
    • Is back linked to this development PR
  • @hal-eisen-MG

@andrejtonev andrejtonev self-assigned this Oct 8, 2024
@andrejtonev andrejtonev added bug bug Docs - changelog only Docs - changelog only CI -build=coverage -test=core Run coverage build and core tests on push CI -build=debug -test=integration Run debug build and integration tests on push CI -build=release -test=e2e Run release build and e2e tests on push labels Oct 8, 2024
@andrejtonev andrejtonev added this to the mg-v2.21.0 milestone Oct 8, 2024
@andrejtonev andrejtonev linked an issue Oct 8, 2024 that may be closed by this pull request
Edge type indexes not working on upgrade #2380
Closed
@andrejtonev andrejtonev changed the title Bugfix: Edge type index incorrect obsolete entry logic Edge index various bugfixes Oct 8, 2024
@andrejtonev andrejtonev requested a review from as51340 October 9, 2024 11:48
@andrejtonev andrejtonev linked an issue Oct 9, 2024 that may be closed by this pull request
Edge index used even when --storage-properties-on-edges is false #2401
Closed
as51340
as51340 approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@as51340 as51340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrejtonev andrejtonev force-pushed the edge_type_index_gc_fix branch from f340267 to 0a82cc3 Compare October 9, 2024 13:00
@andrejtonev andrejtonev changed the title Edge index various bugfixes Bugfix: Various issues with edge index Oct 9, 2024
@andrejtonev andrejtonev enabled auto-merge October 9, 2024 13:01
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
7.3% Duplication on New Code

See analysis details on SonarCloud

@andrejtonev andrejtonev added this pull request to the merge queue Oct 9, 2024
Merged via the queue into master with commit 0f5d436 Oct 9, 2024
@andrejtonev andrejtonev deleted the edge_type_index_gc_fix branch October 9, 2024 15:54
@hal-eisen-MG hal-eisen-MG mentioned this pull request Oct 9, 2024
Merged
10 tasks
@hal-eisen-MG hal-eisen-MG modified the milestones: mg-v2.21.0, mg-v2.20.1 Oct 10, 2024
as51340 pushed a commit that referenced this pull request Oct 24, 2025
@andrejtonev
Bugfix: Various issues with edge index (#2390)
8244abe 
EdgeType index would assign every element as obsolete
EdgeTypeProperty index did not run GC
Allowed edge index creation even when properties on edges was false
Recovered edge indices even if properties on edges was false
EdgeType was not updated via `CreateEdgeEx`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@as51340 as51340 as51340 approved these changes

Assignees

@andrejtonev andrejtonev

Labels

bug bug CI -build=coverage -test=core Run coverage build and core tests on push CI -build=debug -test=integration Run debug build and integration tests on push CI -build=release -test=e2e Run release build and e2e tests on push Docs - changelog only Docs - changelog only

Projects

None yet

Milestone

mg-v2.20.1

Development

Successfully merging this pull request may close these issues.

Edge index used even when --storage-properties-on-edges is false Edge type indexes not working on upgrade

4 participants

@andrejtonev @as51340 @hal-eisen-MG