Add coordinator hostname config #2131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as51340
added
feature
Contributor
Author
Tracking
Standard development
CI Testing Labels
Documentation checklist
|
as51340
force-pushed
the
first-leader-issue
branch
from
db3bf8b to
3eba337
Compare
10 tasks
as51340
force-pushed
the
first-leader-issue
branch
from
3eba337 to
4ec228c
Compare
Contributor
Author
|
@kgolubic all should be written |
as51340
force-pushed
the
first-leader-issue
branch
2 times, most recently
from
8088381 to
d6ae840
Compare
Contributor
antoniofilipovic
left a comment
antoniofilipovic
left a comment
There was a problem hiding this comment.
Good work, I have only one comment
as51340
force-pushed
the
first-leader-issue
branch
from
d6ae840 to
dd15da7
Compare
Contributor
|
I'll use this for RN:
|
as51340
force-pushed
the
first-leader-issue
branch
2 times, most recently
from
8be9d6c to
a9b540f
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
as51340
added
CI -build=coverage -test=core
as51340
added
the
CI -build=debug -test=core
as51340
force-pushed
the
first-leader-issue
branch
from
a9b540f to
2f084b7
Compare
as51340
removed
the
CI -build=coverage -test=core
as51340
force-pushed
the
first-leader-issue
branch
from
2f084b7 to
818a30b
Compare
|
as51340
added a commit
that referenced
this pull request
Oct 24, 2025
Configuration flag `--coordinator-hostname` is added which is used to fix the issue of having 0.0.0.0 in the output of `show instances` on the 1st leader. The flag has its environment variable equivalent in `MEMGRAPH_COORDINATOR_HOSTNAME`. The flag is used solely for the output of `show instances`, from the functional standpoint all stayed the same. High availability e2e tests are changed to use DNS (localhost instead of explicit 127.0.0.1) for consistency reasons. This change is breaking because now all coordinator instances need to provide a configuration option coordinator hostname. The following output can be expected when setting `--coordinator-hostname=localhost` (no data instances): memgraph> show instances; +--------------------+--------------------+--------------------+--------------------+--------------------+--------------------+--------------------+ | name | bolt_server | coordinator_server | management_server | health | role | last_succ_resp_ms | +--------------------+--------------------+--------------------+--------------------+--------------------+--------------------+--------------------+ | "coordinator_1" | "localhost:7690" | "localhost:10111" | "" | "up" | "leader" | 0 | | "coordinator_2" | "localhost:7691" | "localhost:10112" | "" | "up" | "follower" | 45 | | "coordinator_3" | "localhost:7692" | "localhost:10113" | "" | "up" | "follower" | 57 | +--------------------+--------------------+--------------------+--------------------+--------------------+--------------------+--------------------+ 3 rows in set (0.001 sec) memgraph>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration flag
--coordinator-hostnameis added which is used to fix the issue of having 0.0.0.0 in the output ofshow instanceson the 1st leader. The flag has its environment variable equivalent inMEMGRAPH_COORDINATOR_HOSTNAME. The flag is used solely for the output ofshow instances, from the functional standpoint all stayed the same. High availability e2e tests are changed to use DNS (localhost instead of explicit 127.0.0.1) for consistency reasons. This change is breaking because now all coordinator instances need to provide a configuration option coordinator hostname.The following output can be expected when setting
--coordinator-hostname=localhost(no data instances):memgraph> show instances;
+--------------------+--------------------+--------------------+--------------------+--------------------+--------------------+--------------------+
| name | bolt_server | coordinator_server | management_server | health | role | last_succ_resp_ms |
+--------------------+--------------------+--------------------+--------------------+--------------------+--------------------+--------------------+
| "coordinator_1" | "localhost:7690" | "localhost:10111" | "" | "up" | "leader" | 0 |
| "coordinator_2" | "localhost:7691" | "localhost:10112" | "" | "up" | "follower" | 45 |
| "coordinator_3" | "localhost:7692" | "localhost:10113" | "" | "up" | "follower" | 57 |
+--------------------+--------------------+--------------------+--------------------+--------------------+--------------------+--------------------+
3 rows in set (0.001 sec)
memgraph>