Skip to content

Conversation

@as51340
Copy link
Contributor

@as51340 as51340 commented Jun 14, 2024

Description

  1. Validate experimental flag values
  2. Log which experimental features are enabled

[master < Task] PR

  • Provide the full content or a guide for the final git message
    • Improve experimental-enabled flag

CI Testing Labels

Please select the appropriate CI test labels (CI -build=build-name -test=test-suite)

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Experimental-enabled flag is now validated.
    • Users can see logs which experimental features are enabled.
  • Link the documentation PR here
    • [Documentation PR link]
  • Tag someone from docs team in the comments

@as51340 as51340 marked this pull request as ready for review June 15, 2024 12:01
@as51340 as51340 changed the title Experimental fixes Experimental-enabled flag improvements Jun 15, 2024
@as51340 as51340 self-assigned this Jun 15, 2024
@as51340 as51340 added the CI -build=release -test=e2e Run release build and e2e tests on push label Jun 15, 2024
@as51340 as51340 added this to the mg-v2.18.0 milestone Jun 15, 2024
@as51340 as51340 requested a review from Ignition June 15, 2024 12:02
@as51340 as51340 added Docs - changelog only Docs - changelog only feature feature labels Jun 15, 2024
@as51340
Copy link
Contributor Author

as51340 commented Jun 15, 2024

@kgolubic RN written above.

@as51340 as51340 enabled auto-merge June 15, 2024 12:04
@gitbuda
Copy link
Member

gitbuda commented Jun 15, 2024

A bit of random thought, since it’s about logging, this PR might break packaging, specifically THIS -> double check 🙏

@as51340 as51340 added the CI -build=release -test=core Run release build and core tests on push label Jun 17, 2024
@as51340 as51340 added this pull request to the merge queue Jun 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 17, 2024
@as51340 as51340 enabled auto-merge June 17, 2024 15:38
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@as51340 as51340 added this pull request to the merge queue Jun 17, 2024
Merged via the queue into master with commit 2da4743 Jun 17, 2024
@as51340 as51340 deleted the experimental-ux branch June 17, 2024 17:47
@kgolubic
Copy link
Contributor

I will use this for RN:

  • Validation added for the experimental-enabled flag. Users can now view logs
    detailing which experimental features are enabled.
    #2106

as51340 added a commit that referenced this pull request Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI -build=release -test=core Run release build and core tests on push CI -build=release -test=e2e Run release build and e2e tests on push Docs - changelog only Docs - changelog only feature feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants