Skip to content

Conversation

@as51340
Copy link
Contributor

@as51340 as51340 commented Mar 15, 2024

Description

Renamed flags used when setting up HA cluster.

[master < Task] PR

  • Provide the full content or a guide for the final git message
    • Rename flags for setting up HA cluster

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • [Release note text]
  • Link the documentation PR here
  • Tag someone from docs team in the comments

@as51340 as51340 added the Docs needed Docs needed label Mar 15, 2024
@as51340 as51340 added this to the mg-v2.16.0 milestone Mar 15, 2024
@as51340 as51340 self-assigned this Mar 15, 2024
@as51340 as51340 added the feature feature label Mar 15, 2024
@as51340
Copy link
Contributor Author

as51340 commented Mar 15, 2024

@kgolubic docs will be added in batch before 10th April, will post link then.

release note: Renamed HA flags to improve cluster setup

@as51340 as51340 marked this pull request as ready for review March 15, 2024 09:57
Copy link
Contributor

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Do we want to rename also other structs? RaftState -> CoordinatorState, CoordinatorInstance -> ManagementInstance?

@as51340
Copy link
Contributor Author

as51340 commented Mar 18, 2024

We already have CoordinatorState.
CoordinatorInstance sounds better than ManagementInstance to me

@antoniofilipovic
Copy link
Contributor

antoniofilipovic commented Mar 18, 2024

We already have CoordinatorState. CoordinatorInstance sounds better than ManagementInstance to me

I forgot about CoordinatorState. I also like CoordinatorInstance better, but will we be inconsistent then? I am not sure if that is good if we are inconsistent. We can then rename current CoordinatorState to something, and RaftState to CoordinatorState.

Let's sync tomorrow, we can see what is best thing to do

@as51340 as51340 enabled auto-merge (squash) March 21, 2024 06:43
@as51340 as51340 merged commit 0913e95 into master Mar 21, 2024
@as51340 as51340 deleted the rename-ha-flags branch March 21, 2024 09:12
as51340 added a commit that referenced this pull request Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs needed Docs needed feature feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants