Skip to content

Add support for schema.assert #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
as51340 merged 21 commits into from
Nov 21, 2023
Merged

Add support for schema.assert #1485

as51340 merged 21 commits into from
Nov 21, 2023

Conversation

@as51340
Copy link
Contributor

@as51340 as51340 commented Nov 10, 2023 •
edited
Loading

Closes #1519
[master < Epic] PR

  • Check, and update documentation if necessary
  • Write E2E tests
  • Compare the benchmarking results between the master branch and the Epic branch
  • Provide the full content or a guide for the final git message

[master < Task] PR

  • Check, and update documentation if necessary
  • Provide the full content or a guide for the final git message

To keep docs changelog up to date, one more thing to do:

  • Write a release note here, including added/changed clauses
  • Tag someone from docs team in the comments

@as51340 as51340 added the feature feature label Nov 10, 2023
@as51340 as51340 added this to the mg-v2.13.0 milestone Nov 10, 2023
@as51340 as51340 self-assigned this Nov 10, 2023
@as51340 as51340 changed the title Add support schema.assert Add support for schema.assert Nov 13, 2023
@as51340 as51340 marked this pull request as ready for review November 16, 2023 11:14
@as51340 as51340 added the Docs needed Docs needed label Nov 16, 2023
antoniofilipovic
antoniofilipovic reviewed Nov 16, 2023
View reviewed changes
Copy link
Contributor

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, I have some general comments, but will go through this one more time

antoniofilipovic
antoniofilipovic suggested changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentally commented instead of request changes

@as51340 as51340 mentioned this pull request Nov 17, 2023
Closed
10 tasks
antoniofilipovic
antoniofilipovic suggested changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few last changes

@antoniofilipovic
Copy link
Contributor

antoniofilipovic commented Nov 20, 2023

Good work 💪

antoniofilipovic
antoniofilipovic approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@as51340 as51340 force-pushed the schema-assert branch 2 times, most recently from 8036eae to f080348 Compare November 20, 2023 11:15
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 65 Code Smells

No Coverage information No Coverage information
1.6% 1.6% Duplication

@as51340 as51340 merged commit 1d90b60 into master Nov 21, 2023
@as51340 as51340 deleted the schema-assert branch November 21, 2023 08:19
@vpavicic vpavicic mentioned this pull request Nov 30, 2023
Merged
10 tasks
@katarinasupe katarinasupe mentioned this pull request Dec 5, 2023
Closed
as51340 added a commit that referenced this pull request Oct 24, 2025
@as51340
Add schema.assert (#1485)
b295423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@antoniofilipovic antoniofilipovic antoniofilipovic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@as51340 as51340

Labels

Docs needed Docs needed feature feature

Projects

None yet

Milestone

mg-v2.13.0

Development

Successfully merging this pull request may close these issues.

Build schema.assert

3 participants

@as51340 @antoniofilipovic