[master < T1168] Property lookup caching #1168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/memgraph into property-lookup-caching
Josipmrden
requested changes
Aug 18, 2023
Contributor
Josipmrden
left a comment
Josipmrden
left a comment
There was a problem hiding this comment.
Overall good job, but some files are present that should not be.
tests/gql_behave/tests/memgraph_V1/features/property_caching.feature
Outdated
Show resolved
Hide resolved
andrejtonev
reviewed
Aug 18, 2023
Contributor
andrejtonev
left a comment
andrejtonev
left a comment
There was a problem hiding this comment.
Looks good! 💪
Some C++ related comments.
Plus a few places we could maybe gain performance as well. Not sure about them, since I'm missing the big picture. If you want we could jump on a call Monday.
Contributor
Author
|
@vpavicic Release note in the original comment |
antepusic
added
Ship it
Josipmrden
approved these changes
Sep 11, 2023
4 tasks
as51340
pushed a commit
that referenced
this pull request
Nov 10, 2023
as51340
pushed a commit
that referenced
this pull request
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evaluating expressions that contain many same-variable property lookups is slower than optimal because
GetPropertyhas linear complexity. This PR attempts to solve that by preloading and caching all properties of the variables that have multiple property lookups; the properties are cached in the execution context.Related to #1159 (SetProperty optimization).
[master < Task] PR
To keep docs changelog up to date, one more thing to do: