Add temporal type to rsmgp-sys #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antaljanosbenjamin
force-pushed
the
T059-MAGE-temporal-type-to-rsmgp-sys
branch
3 times, most recently
from
9adf16b to
fc79668
Compare
antaljanosbenjamin
added
lang: rust
antaljanosbenjamin
force-pushed
the
T059-MAGE-temporal-type-to-rsmgp-sys
branch
from
fc79668 to
c90b42d
Compare
added 7 commits
October 14, 2021 10:00
antaljanosbenjamin
force-pushed
the
T059-MAGE-temporal-type-to-rsmgp-sys
branch
from
c90b42d to
6dbed22
Compare
antaljanosbenjamin
requested review from
antonio2368,
gitbuda,
jbajic,
jmatak and
kostasrim
jbajic
reviewed
Oct 15, 2021
Comment on lines
+290
to
+298
| pub fn month(&self) -> u32 { | ||
| unsafe { | ||
| invoke_mgp_func!(i32, ffi::mgp_local_date_time_get_month, self.ptr).unwrap() as u32 | ||
| } | ||
| } | ||
|
|
||
| pub fn day(&self) -> u32 { | ||
| unsafe { invoke_mgp_func!(i32, ffi::mgp_local_date_time_get_day, self.ptr).unwrap() as u32 } | ||
| } |
Contributor
There was a problem hiding this comment.
Is there a reason for casting all of these types to uint, since mgp calls return int?
Contributor
Author
There was a problem hiding this comment.
Good question! I meant these classes to used only to convert from/to the chrono types, therefore I adjusted the return types of these function to match the types of the chrono types, e.g. the usage in to_naive_date_time.
jbajic
reviewed
Oct 15, 2021
| Error::UnableToCreateDurationFromChronoDuration | ||
| ); | ||
| }); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.