Skip to content

Conversation

@mattkjames7
Copy link
Contributor

@mattkjames7 mattkjames7 commented Oct 7, 2025

Build improvements

  • speed up build and test by using the mgbuild container to build modules, then do not use mgbuild container as part of the Docker image build.
    amd64 build goes from 15m -> 10m
    arm64 build goes from 18m -> 12m
  • speed up packaging (no tests), e.g. Release amd64: 10m44s -> 6m40s
  • combined packaging and testing into the same workflow, so that fewer overall jobs will need to run (e.g. for daily build and RC build). This has the added advantage that packaging can include testing, so all artifacts will be tested unlike before, where only Release artifacts were tested.
  • moved some more complicated bits of bash scripting from workflows to scripts within scripts/ directory
  • removed Dockerfile.cuda, as that is now handled by Dockerfile.release and the new scripts for installing dependencies
  • removed unused RC_test and Nightly_test jobs, as these are replaced by the Build Release Candidate and Daily Build workflows
  • added experimental DEB package
  • removed some outdated scripts that do not get used

@mattkjames7
Copy link
Contributor Author

mattkjames7 commented Oct 7, 2025

Description

Build improvements

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

  • Core algorithm/module implementation
  • Query module implementation
  • Tests provided (unit / e2e)
  • Code documentation
  • README short description

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Added an experimental Ubuntu-24.04 DEB package to the daily build for installing MAGE modules #678
  • Link the documentation PR here
    • [Documentation PR link]

@mattkjames7 mattkjames7 self-assigned this Oct 16, 2025
@mattkjames7 mattkjames7 added this to the mage-v3.7.0 milestone Oct 16, 2025
@mattkjames7 mattkjames7 added Docs - changelog only Docs - changelog only and removed Docs unnecessary Docs unnecessary labels Nov 4, 2025
@mattkjames7 mattkjames7 marked this pull request as ready for review November 4, 2025 17:09
Copy link
Contributor

@DavIvek DavIvek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments, but overall looks good!

@DavIvek DavIvek self-requested a review November 6, 2025 15:39
@mattkjames7 mattkjames7 enabled auto-merge November 6, 2025 15:48
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 6, 2025

@mattkjames7 mattkjames7 added this pull request to the merge queue Nov 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 6, 2025
@mattkjames7 mattkjames7 added this pull request to the merge queue Nov 6, 2025
Merged via the queue into main with commit ca8e715 Nov 6, 2025
11 checks passed
@mattkjames7 mattkjames7 deleted the build-improvements branch November 6, 2025 16:31
@gitbuda gitbuda mentioned this pull request Nov 13, 2025
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants