Skip to content

Conversation

@tonijurjevic96
Copy link
Contributor

Add apoc.text.indexOf C++ implementation, e2e tests, and fix registration; flake8 checked

@tonijurjevic96
Copy link
Contributor Author

tonijurjevic96 commented Jul 23, 2025

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

  • Core algorithm/module implementation
  • Query module implementation
  • Tests provided (unit / e2e)
  • Code documentation
  • README short description

Documentation checklist

@tonijurjevic96 tonijurjevic96 added Docs unnecessary Docs unnecessary apoc community community customer customer bug bug labels Jul 23, 2025
@tonijurjevic96 tonijurjevic96 added this to the mage-v3.5.0 milestone Jul 23, 2025
@Josipmrden
Copy link
Contributor

Add 2 tests covering to property, one where it finds it, and another one where it doesn't

Copy link
Contributor

@Josipmrden Josipmrden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add newlines to tests since we have the red circle with minus sign under every one, just as a convention.

@sonarqubecloud
Copy link

@tonijurjevic96 tonijurjevic96 added this pull request to the merge queue Jul 23, 2025
Merged via the queue into main with commit 6b8a257 Jul 23, 2025
9 checks passed
@tonijurjevic96 tonijurjevic96 deleted the apoc_indexof branch July 23, 2025 12:44
@gitbuda gitbuda added Docs needed Docs needed and removed Docs unnecessary Docs unnecessary labels Aug 17, 2025
@gitbuda
Copy link
Member

gitbuda commented Aug 17, 2025

@tonijurjevic96, this is a misclassified PR -> at least we have to add the changelog item, but I think the docs update is also required.

@gitbuda gitbuda mentioned this pull request Aug 17, 2025
81 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apoc bug bug community community customer customer Docs needed Docs needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants