Skip to content

Conversation

@mattkjames7
Copy link
Contributor

Now that the build with ML has reduced in size to be comparable with the no-ML build, we can remove the build without ML. This leaves us with 5 images: prod (x86_64/arm64); relwithdebinfo (x86_64/arm64); and malloc (x86_64).

@mattkjames7
Copy link
Contributor Author

mattkjames7 commented Apr 3, 2025

Description

Now that the build with ML has reduced in size to be comparable with the no-ML build, we can remove the build without ML. This leaves us with 5 images: prod (x86_64/arm64); relwithdebinfo (x86_64/arm64); and malloc (x86_64).

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

  • Core algorithm/module implementation
  • Query module implementation
  • Tests provided (unit / e2e)
  • Code documentation
  • README short description

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Significantly improved image build time and size -> there is only "with-ML" image now -> please use that one instead of previous no-ML images. #590
  • Link the documentation PR here
  • Tag someone from docs team in the comments @katarinasupe @gitbuda

@mattkjames7 mattkjames7 marked this pull request as ready for review April 3, 2025 14:48
Copy link
Member

@gitbuda gitbuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is one little comment, but overall seems ok

@mattkjames7 mattkjames7 enabled auto-merge April 4, 2025 16:59
@mattkjames7 mattkjames7 disabled auto-merge April 5, 2025 18:16
@mattkjames7 mattkjames7 enabled auto-merge April 5, 2025 18:16
@mattkjames7 mattkjames7 added this pull request to the merge queue Apr 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Apr 5, 2025
@mattkjames7 mattkjames7 enabled auto-merge April 7, 2025 13:41
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 7, 2025

@mattkjames7 mattkjames7 added this pull request to the merge queue Apr 7, 2025
Merged via the queue into main with commit 5fba411 Apr 7, 2025
8 checks passed
@mattkjames7 mattkjames7 deleted the remove-no-ml branch April 7, 2025 14:50
@gitbuda gitbuda mentioned this pull request Apr 16, 2025
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants