Skip to content

Conversation

@DavIvek
Copy link
Contributor

@DavIvek DavIvek commented Jan 28, 2025

Description

At the moment e2e_correctness tests aren't working under mage testing infrastructure. This PR should fix this issue. Additionally this PR fixes modules that failed on e2e_correctness due to changes PR536

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

  • Core algorithm/module implementation
  • Query module implementation
  • Tests provided (unit / e2e)
  • Code documentation
  • README short description

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Fixed refactor.from() and refactor.delete_and_reconnect(), which did not work as expected in the 3.0.0 release. They now function correctly.
  • Link the documentation PR here
    • [Documentation PR link]
  • Tag someone from docs team in the comments
    @gitbuda @katarinasupe

@DavIvek DavIvek self-assigned this Jan 28, 2025
@imilinovic imilinovic self-requested a review January 28, 2025 17:55
@imilinovic imilinovic linked an issue Jan 28, 2025 that may be closed by this pull request
@DavIvek DavIvek marked this pull request as ready for review January 29, 2025 14:59
@DavIvek DavIvek requested a review from gitbuda January 29, 2025 15:00
@DavIvek DavIvek force-pushed the fix-e2e-correctness-tests branch from c7910d0 to ff55aa5 Compare January 30, 2025 14:14
@DavIvek DavIvek marked this pull request as draft January 30, 2025 14:14
@DavIvek DavIvek requested review from gitbuda and imilinovic January 30, 2025 19:06
@DavIvek DavIvek marked this pull request as ready for review January 30, 2025 19:06
Copy link
Member

@gitbuda gitbuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall much better -> few minor issues, but this PR is in a good enough spot now 💪

@sonarqubecloud
Copy link

@DavIvek DavIvek added Docs unnecessary Docs unnecessary Docs - changelog only Docs - changelog only bug bug and removed Docs unnecessary Docs unnecessary labels Jan 30, 2025
@imilinovic imilinovic merged commit 38cc4a6 into main Jan 30, 2025
7 checks passed
@imilinovic imilinovic deleted the fix-e2e-correctness-tests branch January 30, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

E2E correctness tests are broken on CI

4 participants