Skip to content

Conversation

@imilinovic
Copy link
Contributor

@imilinovic imilinovic commented Jan 14, 2025

Description

EdgeSetTo, EdgeSetFrom and EdgeChangeType were removed from Memgraph and API in PR2530 and some MAGE functions were using those functions so they were rewritten to not use them anymore.

BREAKING: refactor.from, refactor.to, refactor.invert, refactor.delete_and_reconnect and refactor.rename_type now create a new edge instead of modifying the old one. This causes changes if you relied on internal edge ID (previously it would stay the same now it changes due to creation of new edge).

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

  • Core algorithm/module implementation
  • Query module implementation
  • Tests provided (unit / e2e)
  • Code documentation
  • README short description

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • [refactor.from, refactor.to, refactor.invert, refactor.delete_and_reconnect and refactor.rename_type now create a new edge instead of modifying the old one. This causes changes if you relied on internal edge ID (previously it would stay the same now it changes due to creation of new edge). ]
  • Link the documentation PR here
    • [Documentation PR link]
  • [ @gitbuda @katarinasupe ] Tag someone from docs team in the comments

@imilinovic imilinovic added Docs - changelog only Docs - changelog only apoc labels Jan 14, 2025
@imilinovic imilinovic requested a review from DavIvek January 14, 2025 19:13
@imilinovic imilinovic self-assigned this Jan 14, 2025
@gitbuda gitbuda added this to the mage-v1.23 milestone Jan 15, 2025
@sonarqubecloud
Copy link

@imilinovic imilinovic merged commit de90df7 into main Jan 16, 2025
7 checks passed
@imilinovic imilinovic deleted the edge-qm branch January 16, 2025 09:55
@imilinovic imilinovic mentioned this pull request Jan 28, 2025
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants