[E-graphQL < T-collections] Change collections to abide by graphQL #361
+265
−307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpintaric55334
added
status: draft
mpintaric55334
added
status: ready
antoniofilipovic
suggested changes
Sep 19, 2023
Contributor
antoniofilipovic
left a comment
antoniofilipovic
left a comment
There was a problem hiding this comment.
Few changes to do, but looks good
antoniofilipovic
added
status: change
mpintaric55334
added
status: ready
imilinovic
approved these changes
Sep 20, 2023
Contributor
imilinovic
left a comment
imilinovic
left a comment
There was a problem hiding this comment.
Good job! Looks good!
antoniofilipovic
approved these changes
Sep 22, 2023
Contributor
antoniofilipovic
left a comment
antoniofilipovic
left a comment
There was a problem hiding this comment.
Seems good to go
antoniofilipovic
added
status: ship it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please briefly explain the changes you made here.
Pull request type
Related issues
Delete if this PR doesn't resolve any issues. Link the issue if it does.
######################################
Reviewer checklist (the reviewer checks this part)
Module/Algorithm
######################################