Skip to content

[main < T518] Add algo.all_simple_paths #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
antoniofilipovic merged 16 commits into from
Oct 30, 2023
Merged

[main < T518] Add algo.all_simple_paths #356

antoniofilipovic merged 16 commits into from
Oct 30, 2023

Conversation

@imilinovic
Copy link
Contributor

@imilinovic imilinovic commented Sep 14, 2023

Description

Add algo all_simple_paths

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

@imilinovic imilinovic self-assigned this Sep 14, 2023
@imilinovic imilinovic added In progress type: algorithm Initial algorithm implementation labels Sep 14, 2023
@imilinovic imilinovic changed the base branch from main to E-add-algo-module September 14, 2023 14:47
@imilinovic imilinovic mentioned this pull request Sep 19, 2023
Merged
4 tasks
@imilinovic
Copy link
Contributor Author

imilinovic commented Sep 19, 2023

Requires:
Memgraph PR1249

@antoniofilipovic antoniofilipovic added this to the 1.12.0 milestone Oct 17, 2023
@imilinovic imilinovic added status: ready PR is ready for review Docs needed Docs needed and removed type: algorithm Initial algorithm implementation In progress Needs new memgraph labels Oct 25, 2023
@imilinovic imilinovic marked this pull request as ready for review October 25, 2023 23:26
Base automatically changed from E-add-algo-module to main October 26, 2023 12:42
@mpintaric55334 mpintaric55334 mentioned this pull request Oct 26, 2023
Merged
10 tasks
antoniofilipovic
antoniofilipovic suggested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, but left two comments to make it more optimal

@antoniofilipovic antoniofilipovic added status: change PR reviewed - needs changes and removed status: ready PR is ready for review labels Oct 26, 2023
@imilinovic imilinovic added status: ready PR is ready for review and removed status: change PR reviewed - needs changes labels Oct 26, 2023
@antoniofilipovic antoniofilipovic added status: ship it PR approved status: resolve conflicts and removed status: ready PR is ready for review labels Oct 27, 2023
@imilinovic imilinovic changed the title [E-algo < T518] Add algo.all_simple_paths [main < T518] Add algo.all_simple_paths Oct 27, 2023
@antoniofilipovic antoniofilipovic merged commit c093429 into main Oct 30, 2023
@antoniofilipovic antoniofilipovic deleted the T518-allSimplePaths branch October 30, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@antoniofilipovic antoniofilipovic antoniofilipovic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@imilinovic imilinovic

Labels

Docs needed Docs needed status: ship it PR approved

Projects

mage
Status: Done

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

4 participants

@imilinovic @antoniofilipovic @mpintaric55334