Skip to content

[main < E-schema] Implement nodeTypeProperties and relTypeProperties #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
antoniofilipovic merged 37 commits into from
Sep 11, 2023
Merged

[main < E-schema] Implement nodeTypeProperties and relTypeProperties #341

antoniofilipovic merged 37 commits into from
Sep 11, 2023

Conversation

@mpintaric55334
Copy link
Contributor

@mpintaric55334 mpintaric55334 commented Sep 5, 2023

Description

Please briefly explain the changes you made here.

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

idoraban and others added 29 commits August 2, 2023 09:09
add initial structure
de3e42b
implement date.parse
8a0816a
remove cpp date module
bc74ca0
rename python date module
1f3de7e
remove cpp date module
d3bae6b
add date.format draft
7653423
add e2e date.format tests
92360ea
implement label.exists and e2e tests for it
f322d38
add missing endline
39bec4e
edit wrong procedure call
5b41866
edit by review comments
eb487ab
edit typing error
84464b4
format files with black
5a863a3
@antoniofilipovic
Merge branch 'main' into T585-T586-MAGE-implement-date
71c6435
@imilinovic
Merge branch 'main' into T585-T586-MAGE-implement-date
995fe4d
@antoniofilipovic
Merge branch 'main' into T585-T586-MAGE-implement-date
cdd5071
@ind1xa
Merge branch 'main' into T510-MAGE-implement-label
07ed16d
@antepusic
Merge pull request #304 from memgraph/T510-MAGE-implement-label
158919a 
[main < T510] Implement label.exists
@ind1xa
Merge branch 'main' into T585-T586-MAGE-implement-date
456a7ba
@antepusic
Merge pull request #291 from memgraph/T585-T586-MAGE-implement-date
e59093a 
[main < T585 T586] Implement date functions
@mpintaric55334
merge
c39f0cd
@mpintaric55334
Merge branch 'main' of https://github.com/memgraph/mage
2aca436
@mpintaric55334
Pull
731774f
@mpintaric55334
Merge branch 'main' of https://github.com/memgraph/mage
fa5f222
@mpintaric55334
Merge branch 'main' of https://github.com/memgraph/mage
0cc8e82
@mpintaric55334
Merge branch 'main' of https://github.com/memgraph/mage
7b334da
@mpintaric55334
Merge branch 'main' of https://github.com/memgraph/mage
6174dbf
@mpintaric55334
Merge branch 'main' of https://github.com/memgraph/mage
c4277cc
@mpintaric55334
Implement schema.nodeTypeProperties and schema.relTypeProperties
77a3a70
@mpintaric55334 mpintaric55334 added the status: ready PR is ready for review label Sep 5, 2023
@mpintaric55334 mpintaric55334 self-assigned this Sep 5, 2023
@mpintaric55334 mpintaric55334 changed the title [master < E-schema] Implemen nodeTypeProperties and relTypeProperties [master < E-schema] Implement nodeTypeProperties and relTypeProperties Sep 5, 2023
@mpintaric55334 mpintaric55334 changed the title [master < E-schema] Implement nodeTypeProperties and relTypeProperties [main < E-schema] Implement nodeTypeProperties and relTypeProperties Sep 5, 2023
antoniofilipovic
antoniofilipovic reviewed Sep 7, 2023
View reviewed changes
antoniofilipovic
antoniofilipovic reviewed Sep 7, 2023
View reviewed changes
antoniofilipovic
antoniofilipovic reviewed Sep 7, 2023
View reviewed changes
antoniofilipovic
antoniofilipovic suggested changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion and one comment and that should be it

@antoniofilipovic antoniofilipovic added status: change PR reviewed - needs changes and removed status: ready PR is ready for review labels Sep 7, 2023
@mpintaric55334 mpintaric55334 added status: ready PR is ready for review and removed status: change PR reviewed - needs changes labels Sep 8, 2023
antoniofilipovic
antoniofilipovic approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go

@antoniofilipovic antoniofilipovic added status: ship it PR approved and removed status: ready PR is ready for review labels Sep 8, 2023
@mpintaric55334 mpintaric55334 mentioned this pull request Sep 11, 2023
Open
6 tasks
@antoniofilipovic antoniofilipovic merged commit 868339e into main Sep 11, 2023
@antoniofilipovic antoniofilipovic deleted the E-schema-functions branch September 11, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@antoniofilipovic antoniofilipovic antoniofilipovic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mpintaric55334 mpintaric55334

Labels

status: ship it PR approved type: module

Projects

mage
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mpintaric55334 @antoniofilipovic @imilinovic @ind1xa @antepusic