-
Notifications
You must be signed in to change notification settings - Fork 34
[main < T350-MAGE] Implement graphml import and export #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
python/export_util.py
Outdated
| if graphML: | ||
| properties = { | ||
| key: convert_to_isoformat_graphML(vertex.properties.get(key)) | ||
| for key in vertex.properties.keys() | ||
| } | ||
| else: | ||
| properties = { | ||
| key: convert_to_isoformat(vertex.properties.get(key)) | ||
| for key in vertex.properties.keys() | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| if graphML: | |
| properties = { | |
| key: convert_to_isoformat_graphML(vertex.properties.get(key)) | |
| for key in vertex.properties.keys() | |
| } | |
| else: | |
| properties = { | |
| key: convert_to_isoformat(vertex.properties.get(key)) | |
| for key in vertex.properties.keys() | |
| } | |
| if graphML: | |
| properties = { | |
| key: convert_to_isoformat_graphML(vertex.properties.get(key)) | |
| for key in vertex.properties.keys() | |
| } | |
| continue | |
| properties = { | |
| key: convert_to_isoformat(vertex.properties.get(key)) | |
| for key in vertex.properties.keys() | |
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but wont continue go to the next vertex in ctx.graph.vertices and lines below will be skipped?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes but isn't that okay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really, i want those properties to be added to the node in both cases, just in different format (depending if its for graphml or not)
antoniofilipovic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, left few comments to do
antepusic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments, I'll take a more detailed look later too :)
antoniofilipovic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
…E-implement-graphml
…raph/mage into T350-MAGE-implement-graphml
Description
Implemented import_util.graphml and export_util.graphml
Pull request type
######################################
Reviewer checklist (the reviewer checks this part)
Module/Algorithm
######################################