Skip to content

Conversation

@antepusic
Copy link
Contributor

Description

This PR addresses the issue of checks failing because the order of properties in llm_util.schema('prompt_ready') is not deterministic. The fix is to sort the properties before outputting them, and e2e tests are updated to reflect that.

Pull request type

  • Bugfix

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

@antepusic antepusic added type: bug Something isn't working lang: python Issue on Python codebase status: ready PR is ready for review labels Aug 22, 2023
@antepusic antepusic self-assigned this Aug 22, 2023
@imilinovic
Copy link
Contributor

imilinovic commented Aug 23, 2023

You are missing newlines at the end of some tests, but that can be added after tests pass.

Also it should probably be added to the schema documentation that the properties are sorted now.

@gitbuda gitbuda merged commit 629c026 into main Aug 23, 2023
@gitbuda gitbuda deleted the consistent-llm_util-output branch August 23, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang: python Issue on Python codebase status: ready PR is ready for review type: bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants