Skip to content

[main < T599-MAGE] Implement temporal #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
antoniofilipovic merged 30 commits into from
Sep 4, 2023
Merged

[main < T599-MAGE] Implement temporal #299

antoniofilipovic merged 30 commits into from
Sep 4, 2023

Conversation

@ind1xa
Copy link
Contributor

@ind1xa ind1xa commented Aug 8, 2023

Description

Implemented temporal.format procedure and e2e tests for it.

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

@ind1xa ind1xa added the status: draft PR is in draft phase label Aug 8, 2023
@ind1xa ind1xa requested a review from antoniofilipovic August 8, 2023 09:33
@ind1xa ind1xa self-assigned this Aug 8, 2023
@ind1xa ind1xa added status: ready PR is ready for review and removed status: draft PR is in draft phase labels Aug 9, 2023
@ind1xa ind1xa marked this pull request as ready for review August 9, 2023 07:57
imilinovic
imilinovic requested changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@imilinovic imilinovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format all Python files with black.
Example: python3 -m black python/temporal.py
Otherwise looks good.

@imilinovic imilinovic added status: change PR reviewed - needs changes and removed status: ready PR is ready for review labels Aug 9, 2023
@ind1xa ind1xa requested a review from imilinovic August 9, 2023 15:32
@ind1xa ind1xa added status: ready PR is ready for review and removed status: change PR reviewed - needs changes labels Aug 9, 2023
Josipmrden
Josipmrden reviewed Aug 10, 2023
View reviewed changes
@ind1xa @Josipmrden
PR changes
ba76d94 
Co-authored-by: Josipmrden <josip.mrden@memgraph.io>
@ind1xa ind1xa requested a review from Josipmrden August 10, 2023 07:01
@antoniofilipovic antoniofilipovic added status: ship it PR approved and removed status: ready PR is ready for review labels Aug 11, 2023
This was referenced Aug 16, 2023
Merged
Merged
@Ignition Ignition force-pushed the main branch 2 times, most recently from 6137a25 to 7db747a Compare August 22, 2023 14:10
@ind1xa ind1xa mentioned this pull request Aug 23, 2023
Merged
6 tasks
imilinovic
imilinovic approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@imilinovic imilinovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@antoniofilipovic antoniofilipovic merged commit 68845db into main Sep 4, 2023
@antoniofilipovic antoniofilipovic deleted the T599-MAGE-implement-temporal branch September 4, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imilinovic imilinovic imilinovic approved these changes

@mpintaric55334 mpintaric55334 Awaiting requested review from mpintaric55334

@Josipmrden Josipmrden Awaiting requested review from Josipmrden

+1 more reviewer

@antoniofilipovic antoniofilipovic antoniofilipovic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ind1xa ind1xa

Labels

status: ship it PR approved

Projects

mage
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ind1xa @Josipmrden @imilinovic @antoniofilipovic @antepusic