[main < T585 T586] Implement date functions #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniofilipovic
suggested changes
Aug 6, 2023
Contributor
antoniofilipovic
left a comment
antoniofilipovic
left a comment
There was a problem hiding this comment.
Few comments, but overall good work.
python/date_module.py
Outdated
| HOURS_IN_DAY = 24 | ||
| UNIX_EPOCH = datetime.datetime(1970, 1, 1, 0, 0, 0) | ||
|
|
||
| def getOffset(timezone, date): |
Contributor
There was a problem hiding this comment.
Are there any Typings from pytz library we can use here? So that we have suggestion which type is sent here
Contributor
Author
There was a problem hiding this comment.
I'm not sure I understand the question. Could you rephrase please?
Contributor
There was a problem hiding this comment.
Aha, typings yet. Yes sorry. So on Python, you have typings, https://docs.python.org/3/library/typing.html. Are there any available on pytz library which you can use in this case?
antoniofilipovic
added
status: change
ind1xa
added
status: ready
antoniofilipovic
approved these changes
Aug 9, 2023
Contributor
antoniofilipovic
left a comment
antoniofilipovic
left a comment
There was a problem hiding this comment.
Looks good to me
antoniofilipovic
added
status: ship it
This was referenced Aug 16, 2023
Ignition
pushed a commit
that referenced
this pull request
Aug 22, 2023
Also added e2e tests for them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented date.parse and date.format procedures and e2e tests for them.
Pull request type
######################################
Reviewer checklist (the reviewer checks this part)
Module/Algorithm
######################################