Skip to content

Conversation

@imilinovic
Copy link
Contributor

@imilinovic imilinovic commented Aug 3, 2023

Description

Implement text.join

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

@imilinovic imilinovic added the status: ready PR is ready for review label Aug 3, 2023
@imilinovic imilinovic self-assigned this Aug 3, 2023
Copy link
Contributor

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change

@antoniofilipovic antoniofilipovic added status: change PR reviewed - needs changes and removed status: ready PR is ready for review labels Aug 6, 2023
@imilinovic imilinovic added status: ready PR is ready for review and removed status: change PR reviewed - needs changes labels Aug 8, 2023
Copy link
Contributor

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@antoniofilipovic antoniofilipovic added status: ship it PR approved and removed status: ready PR is ready for review labels Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ship it PR approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants