[E-ivan < T413] Implement collections.sumLongs #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imilinovic
changed the title
imilinovic
changed the title
| const auto record_factory = mgp::RecordFactory(result); | ||
|
|
||
| try { | ||
| int64_t sum = 0; |
Contributor
There was a problem hiding this comment.
Suggested change
| int64_t sum = 0; | |
| int64_t sum{0}; |
| const auto &list = arguments[0].ValueList(); | ||
|
|
||
| for (const auto list_item : list){ | ||
| if(!list_item.IsNumeric()) |
Contributor
There was a problem hiding this comment.
Same comment as on other PR to use {} for if statement
antoniofilipovic
suggested changes
Jul 19, 2023
Contributor
antoniofilipovic
left a comment
antoniofilipovic
left a comment
There was a problem hiding this comment.
Few comments, looks good!
| record_factory.SetErrorMessage(e.what()); | ||
| return; | ||
| } | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
Add empty lines here too
|
|
||
| namespace Collections{ | ||
|
|
||
| constexpr const char *kResultSumLongs = "sum"; |
Contributor
There was a problem hiding this comment.
const char * is a global that may change. use constexpr std::string_view for better code stlye
Contributor
Author
There was a problem hiding this comment.
In this exact place kResultSumLongs needs to be char* because field_name in record.Insert() needs to be char*, changed in other places.
Contributor
There was a problem hiding this comment.
You can use on that std::string(kResultSumLongs).c_str()
imilinovic
changed the title
imilinovic
changed the title
imilinovic
changed the title
antoniofilipovic
added
status: ship it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented collections.sumLongs and added test for it.
Pull request type
######################################
Reviewer checklist (the reviewer checks this part)
Module/Algorithm
######################################