Skip to content

[E-collections < E-ivan-collections] Add part of collections functions #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
imilinovic merged 12 commits into from
Aug 2, 2023
Merged

[E-collections < E-ivan-collections] Add part of collections functions #234

imilinovic merged 12 commits into from
Aug 2, 2023

Conversation

@imilinovic
Copy link
Contributor

@imilinovic imilinovic commented Jul 18, 2023 •
edited
Loading

Description

Add collections functions and tests for each of them.

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

@imilinovic imilinovic self-assigned this Jul 18, 2023
@imilinovic imilinovic marked this pull request as draft July 18, 2023 14:22
@antoniofilipovic antoniofilipovic changed the title [E-add-collections-functions < E-ivan-add-collections] Add collections functions [E-collections < E-ivan-collections] Add part of collections functions Jul 26, 2023
@imilinovic imilinovic changed the base branch from main to E-add-collections-functions July 27, 2023 13:16
@imilinovic imilinovic marked this pull request as ready for review July 27, 2023 13:31
antoniofilipovic
antoniofilipovic approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@antoniofilipovic antoniofilipovic added the status: ship it PR approved label Jul 28, 2023
antoniofilipovic
antoniofilipovic reviewed Jul 28, 2023
View reviewed changes
antoniofilipovic
antoniofilipovic suggested changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, few formatting changes

@antoniofilipovic antoniofilipovic added status: change PR reviewed - needs changes and removed status: ship it PR approved labels Jul 28, 2023
@imilinovic imilinovic added status: ready PR is ready for review and removed status: change PR reviewed - needs changes labels Jul 31, 2023
antoniofilipovic
antoniofilipovic approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@antoniofilipovic antoniofilipovic added status: ship it PR approved and removed status: ready PR is ready for review labels Jul 31, 2023
antoniofilipovic
antoniofilipovic reviewed Aug 1, 2023
View reviewed changes
antoniofilipovic
antoniofilipovic reviewed Aug 1, 2023
View reviewed changes
@antoniofilipovic antoniofilipovic added status: change PR reviewed - needs changes and removed status: ship it PR approved labels Aug 1, 2023
@antoniofilipovic
Copy link
Contributor

antoniofilipovic commented Aug 1, 2023

Actually, just remove these references

@imilinovic imilinovic added status: ready PR is ready for review and removed status: change PR reviewed - needs changes labels Aug 2, 2023
@antoniofilipovic antoniofilipovic added status: ship it PR approved and removed status: ready PR is ready for review labels Aug 2, 2023
@imilinovic imilinovic merged commit 2250c8f into E-add-collections-functions Aug 2, 2023
@imilinovic imilinovic deleted the E-ivan-add-collections branch August 2, 2023 09:20
@imilinovic imilinovic restored the E-ivan-add-collections branch August 2, 2023 10:32
@imilinovic imilinovic deleted the E-ivan-add-collections branch August 2, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ind1xa ind1xa Awaiting requested review from ind1xa

@mpintaric55334 mpintaric55334 Awaiting requested review from mpintaric55334

1 more reviewer

@antoniofilipovic antoniofilipovic antoniofilipovic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@imilinovic imilinovic

Labels

status: ship it PR approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@imilinovic @antoniofilipovic