[main < T222] Rewrite the do module in C++ #222
Conversation
e2e/do_test/type_conversion_group/test_return_node_relationship/test.yml
Outdated
Show resolved
Hide resolved
antoniofilipovic
left a comment
antoniofilipovic
left a comment
There was a problem hiding this comment.
Few minor suggestions, otherwise seems good
|
|
||
| return fmt::format("WITH {}", Join(with_entity_vector, ", ")); | ||
| } | ||
|
|
There was a problem hiding this comment.
Does it make sense to use here std::move on node_names
|
|
||
| void InsertConditionalResults(const mgp::RecordFactory &record_factory, const QueryResults &query_results) { | ||
| for (const auto &row : query_results.results) { | ||
| auto result_map = mgp::Map(); |
There was a problem hiding this comment.
prefer initialization to assignment:
mgp::Map result_map;
There was a problem hiding this comment.
FYI that is construction, no assignment is involved. see https://godbolt.org/z/8P78MeWrW
There was a problem hiding this comment.
@Ignition I thought all the time it was an assignment, thanks 👍
|
@Josipmrden release note pliz |
|
@Josipmrden ok? The |
antoniofilipovic
left a comment
antoniofilipovic
left a comment
There was a problem hiding this comment.
Looks good to me
Description
This pull request concerns rewriting the
domodule and its corresponding methods (do.caseanddo.when) in C++ for increase of performancePull request type
######################################
Reviewer checklist (the reviewer checks this part)
Module/Algorithm
######################################