Skip to content

Make Graph Coloring output vertices and integers instead of strings #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
antoniofilipovic merged 3 commits into from
Nov 21, 2022
Merged

Make Graph Coloring output vertices and integers instead of strings #177

antoniofilipovic merged 3 commits into from
Nov 21, 2022

Conversation

@brunos252
Copy link
Contributor

@brunos252 brunos252 commented Nov 16, 2022 •
edited by antoniofilipovic
Loading

Description

As was requested, outputs of Graph Coloring algorithm were changed from vertex_id and string representing color to mgp.Vertex and int

Pull request type

  • Feature

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

  • Core algorithm/module implementation
  • Query module implementation
  • Unit tests
  • End-to-end tests
  • Code documentation
  • README short description
  • Documentation on memgraph/docs

######################################

@brunos252 brunos252 self-assigned this Nov 16, 2022
antepusic
antepusic approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@antepusic antepusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me!

@antoniofilipovic antoniofilipovic added the status: ship it PR approved label Nov 20, 2022
@antoniofilipovic antoniofilipovic merged commit ad5952a into main Nov 21, 2022
@antoniofilipovic antoniofilipovic deleted the graph-coloring-output-vertex branch November 21, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@as51340 as51340 as51340 approved these changes

@BorisTasevski BorisTasevski Awaiting requested review from BorisTasevski

@Josipmrden Josipmrden Awaiting requested review from Josipmrden

@niko4299 niko4299 Awaiting requested review from niko4299

+2 more reviewers

@antepusic antepusic antepusic approved these changes

@antoniofilipovic antoniofilipovic antoniofilipovic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@brunos252 brunos252

Labels

status: ship it PR approved

Projects

mage
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@brunos252 @antepusic @as51340 @antoniofilipovic