Skip to content

[main < T469-FL] Fix reset, class label and early stopping bugs on node classification module #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
antoniofilipovic merged 10 commits into from
Nov 14, 2022
Merged

[main < T469-FL] Fix reset, class label and early stopping bugs on node classification module #173

antoniofilipovic merged 10 commits into from
Nov 14, 2022

Conversation

@antoniofilipovic
Copy link
Contributor

@antoniofilipovic antoniofilipovic commented Nov 8, 2022 •
edited
Loading

Description

This PR includes three bugfixes:

  • training throws an error after calling the reset method
  • training not working if class labels don't start with 0
  • potential bug for early stopping on the first iteration if val_loss > 100

Pull request type

  • Bugfix

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

  • Core algorithm/module implementation
  • Query module implementation
  • Unit tests
  • End-to-end tests
  • Code documentation
  • README short description
  • Documentation on memgraph/docs

######################################

@antoniofilipovic antoniofilipovic self-assigned this Nov 8, 2022
niko4299
niko4299 approved these changes Nov 9, 2022
View reviewed changes
@antoniofilipovic antoniofilipovic changed the title [main < T469-FL] Fix reset on node classification [main < T469-FL] Fix reset, class label and early stopping bugs on node classification module Nov 9, 2022
antepusic
antepusic reviewed Nov 9, 2022
View reviewed changes
Copy link
Contributor

@antepusic antepusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good so far 🚀

@antoniofilipovic antoniofilipovic added the status: ready PR is ready for review label Nov 10, 2022
@antoniofilipovic antoniofilipovic merged commit 4a589fe into main Nov 14, 2022
@antoniofilipovic antoniofilipovic deleted the T469-FL-fix-reset-node-classification branch November 14, 2022 13:32
@antepusic antepusic added status: ship it PR approved and removed status: ready PR is ready for review labels Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@as51340 as51340 Awaiting requested review from as51340

2 more reviewers

@antepusic antepusic antepusic approved these changes

@niko4299 niko4299 niko4299 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@antoniofilipovic antoniofilipovic

Labels

status: ship it PR approved

Projects

mage
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@antoniofilipovic @antepusic @niko4299