Query module for connecting to ElasticSearch #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as51340
added
lang: python
as51340
changed the title
as51340
changed the title
antoniofilipovic
suggested changes
Oct 6, 2022
BorisTasevski
suggested changes
Oct 7, 2022
Contributor
antoniofilipovic
left a comment
antoniofilipovic
left a comment
There was a problem hiding this comment.
Check the comment for the singleton class, we can discuss how to proceed but I think we need at least unit tests for this. When you implement a singleton class in unit tests we could mock elasticsearch. How does this sound to you?
BorisTasevski
suggested changes
Oct 19, 2022
antoniofilipovic
removed
status: ready
Josipmrden
requested review from
BorisTasevski
and removed request for
BorisTasevski
BorisTasevski
approved these changes
Jan 3, 2023
antoniofilipovic
requested review from
BorisTasevski
and removed request for
BorisTasevski
| HITS = "hits" | ||
| TOTAL = "total" | ||
|
|
||
| # Linkurious constants |
Contributor
There was a problem hiding this comment.
I think we should remove anything that has connection with clients
Contributor
Author
There was a problem hiding this comment.
Yes, this was left accidently, I removed other things.
antoniofilipovic
approved these changes
Jan 19, 2023
Contributor
antoniofilipovic
left a comment
antoniofilipovic
left a comment
There was a problem hiding this comment.
Remove the connection to Linkurious and we are ready to ship it.
…graph/mage into Memgraph-serialization-ElasticSearch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Query module which enables developers to serialize Memgraph into Elastic search instance using basic authentication. It can also scan based on the query given. It indexes documents using bulking_scan.
Pull request type
######################################
Reviewer checklist (the reviewer checks this part)
Module/Algorithm
######################################