Skip to content

Conversation

@antepusic
Copy link
Contributor

@antepusic antepusic commented Jun 27, 2022

Description

Extend the community_detection module to allow restricting community detection to subgraphs.

Pull request type

  • Feature

Related issues

#149

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

  • Core algorithm/module implementation
  • Query module implementation
  • Unit tests
  • End-to-end tests
  • Code documentation
  • README short description
  • Documentation on memgraph/docs

######################################

@antepusic antepusic added type: enhancement lang: cpp Issue on C++ codebase status: ready PR is ready for review labels Jun 27, 2022
@antepusic antepusic self-assigned this Jun 27, 2022
@antepusic antepusic linked an issue Jun 27, 2022 that may be closed by this pull request
@antepusic antepusic changed the title Fixes #149 Allow restricting community detection to subgraphs Jun 27, 2022
Copy link
Contributor

@jmatak jmatak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added some comments, mostly pointing to the changes related to the repetition of code.

@antepusic
Copy link
Contributor Author

antepusic commented Jul 4, 2022

I have added some comments, mostly pointing to the changes related to the repetition of code.

Thanks for the review! The current state of the branch is basically a minimum viable solution, and I’m eliminating repetition now.

@antepusic antepusic added status: change PR reviewed - needs changes and removed status: ready PR is ready for review labels Jul 5, 2022
@antepusic antepusic requested a review from jmatak July 5, 2022 13:08
@antepusic antepusic added status: ready PR is ready for review and removed status: change PR reviewed - needs changes labels Jul 5, 2022
Copy link
Contributor

@jmatak jmatak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much better, it's much clear to distinguish between weighted graph and subgraph.

@antepusic
Copy link
Contributor Author

@threedliteguy: Hi Dan! The PR adding community detection on subgraphs has been approved - come and try it out 🙂

Copy link
Contributor

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two comments to discuss, so I will put request changes since it seems like we could use both of them.

@antepusic antepusic added status: change PR reviewed - needs changes and removed status: ready PR is ready for review labels Jul 11, 2022
Copy link
Contributor

@jmatak jmatak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antoniofilipovic Left some good notes, shouldn't be much of a hassle to refactor that.

@antepusic antepusic requested a review from jmatak July 26, 2022 07:13
@antepusic antepusic added status: ready PR is ready for review and removed status: change PR reviewed - needs changes labels Jul 26, 2022
Copy link
Contributor

@jmatak jmatak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unify CreateEdge in mg_graph.hpp and fix creating node return value when node is already created.

@jmatak
Copy link
Contributor

jmatak commented Aug 16, 2022

@antepusic Comment out here the link to memgraph/docs PR

@antepusic
Copy link
Contributor Author

@antepusic Comment out here the link to memgraph/docs PR

Here you are: memgraph/docs#450

Copy link
Contributor

@jmatak jmatak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished 🎉

@jmatak jmatak merged commit 768773d into main Aug 22, 2022
@jmatak jmatak deleted the T262-MAGE_Louvain-subgraph branch August 22, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang: cpp Issue on C++ codebase status: ready PR is ready for review

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add ability to execute CALL on subgraph

5 participants