-
Notifications
You must be signed in to change notification settings - Fork 34
Allow restricting community detection to subgraphs #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jmatak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added some comments, mostly pointing to the changes related to the repetition of code.
Thanks for the review! The current state of the branch is basically a minimum viable solution, and I’m eliminating repetition now. |
jmatak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much better, it's much clear to distinguish between weighted graph and subgraph.
|
@threedliteguy: Hi Dan! The PR adding community detection on subgraphs has been approved - come and try it out 🙂 |
antoniofilipovic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two comments to discuss, so I will put request changes since it seems like we could use both of them.
jmatak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@antoniofilipovic Left some good notes, shouldn't be much of a hassle to refactor that.
jmatak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unify CreateEdge in mg_graph.hpp and fix creating node return value when node is already created.
|
@antepusic Comment out here the link to |
Here you are: memgraph/docs#450 |
jmatak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished 🎉
Description
Extend the
community_detectionmodule to allow restricting community detection to subgraphs.Pull request type
Related issues
#149
######################################
Reviewer checklist (the reviewer checks this part)
Module/Algorithm
######################################