Skip to content
This repository was archived by the owner on Sep 18, 2023. It is now read-only.

Conversation

@ind1xa
Copy link
Contributor

@ind1xa ind1xa commented Aug 16, 2023

Description

Add documentation for neighbors module.

Pull request type

Please delete options that are not relevant and check the ones that are.

  • New documentation page

Related PRs and issues

PR this doc page is related to: memgraph/mage#308
Closes (link to issue):

Checklist:

  • I checked all content with Grammarly
  • I performed a self-review of my code
  • I made corresponding changes to the rest of the documentation
  • The build passes locally
  • My changes generate no new warnings or errors

@ind1xa ind1xa added the status: ready PR is ready for review label Aug 16, 2023
@ind1xa ind1xa self-assigned this Aug 16, 2023
Comment on lines 44 to 46
- `node: Node` ➡ node whose neighborhood is being analyzed
- `rel_type: List[string]` ➡ list of relationship types to travel through; if empty, it is possible to travel through all types of relationships
- `distance: int` ➡ number of hops between nodes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `node: Node` ➡ node whose neighborhood is being analyzed
- `rel_type: List[string]` ➡ list of relationship types to travel through; if empty, it is possible to travel through all types of relationships
- `distance: int` ➡ number of hops between nodes
- `node: Node` ➡ node whose neighborhood is being analyzed.
- `rel_type: List[string]` ➡ list of relationship types to travel through; if empty, it is possible to travel through all types of relationships.
- `distance: int` ➡ number of hops between nodes.


#### Output:

- `nodes: Node` ➡ nodes at a specific distance from a given node
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `nodes: Node` ➡ nodes at a specific distance from a given node
- `nodes: Node` ➡ nodes at a specific distance from a given node.

Comment on lines 73 to 75
- `node: Node` ➡ node whose neighborhood is being analyzed
- `rel_type: List[string]` ➡ list of relationship types to travel through; if empty, it is possible to travel through all types of relationships
- `distance: int` ➡ maximum number of hops between nodes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `node: Node` ➡ node whose neighborhood is being analyzed
- `rel_type: List[string]` ➡ list of relationship types to travel through; if empty, it is possible to travel through all types of relationships
- `distance: int` ➡ maximum number of hops between nodes
- `node: Node` ➡ node whose neighborhood is being analyzed.
- `rel_type: List[string]` ➡ list of relationship types to travel through; if empty, it is possible to travel through all types of relationships.
- `distance: int` ➡ maximum number of hops between nodes.


#### Output:

- `nodes: List[Node]` ➡ list of nodes at a specific distance from a given node, starting from distance 1 up to a provided distance
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `nodes: List[Node]` ➡ list of nodes at a specific distance from a given node, starting from distance 1 up to a provided distance
- `nodes: List[Node]` ➡ list of nodes at a specific distance from a given node, starting from distance 1 up to a provided distance.


#### Input:

- `node: Node` ➡ node whose neighborhood is being analyzed.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `node: Node` ➡ node whose neighborhood is being analyzed.
- `node: Node` ➡ node for which neighborhood is being analyzed.

nodes are not persons

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please change that across all of your prs?


### `by_hop(node, rel_type, distance)`

Returns nodes that are at every distance (up to a specified number) from a given node, considering only the relationships of a specified type.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Returns nodes that are at every distance (up to a specified number) from a given node, considering only the relationships of a specified type.
Returns nodes that are at any or up to a specific distance from a given node, considering only the relationships of a specified type.

Copy link
Collaborator

@vpavicic vpavicic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the whose and 1 sentence

@vpavicic vpavicic added status: change PR reviewed - needs changes and removed status: ready PR is ready for review labels Aug 30, 2023
@ind1xa ind1xa added status: ready PR is ready for review and removed status: change PR reviewed - needs changes labels Aug 30, 2023
@ind1xa ind1xa requested a review from vpavicic August 30, 2023 13:52
@vpavicic vpavicic added status: ship it PR approved and removed status: ready PR is ready for review labels Aug 30, 2023
@ind1xa ind1xa merged commit 599cdad into master Aug 31, 2023
@ind1xa ind1xa deleted the E-add-neighbors-docs branch August 31, 2023 05:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants