Skip to content

Conversation

@martinvonk
Copy link
Contributor

@martinvonk martinvonk commented Jan 29, 2026

Allright I did a few things:

  • Create a test to run the notebooks with _sol. This can also be run locally via pytest .github/workflows/test_notebooks.py
  • Update some of the notebooks in order for them to run again (related to pylab, notebook v3, old numpy versions etc.)
  • Remove 3 old .ipynb_checkpoints

@martinvonk
Copy link
Contributor Author

martinvonk commented Feb 2, 2026

Okay I tweaked this PR and now all notebooks are updated and tested. Also running the test on the first day of the month works.

@mbakker7
Copy link
Owner

mbakker7 commented Feb 2, 2026

Thanks, @martinvonk !
As you saw, there was quite some maintenance to be done. I appreciate your help.

@mbakker7
Copy link
Owner

mbakker7 commented Feb 2, 2026

Ready to go?

@martinvonk
Copy link
Contributor Author

Yes ready to go now. All tests pass :)

@mbakker7
Copy link
Owner

mbakker7 commented Feb 2, 2026

How do you run a test on notebooks7_bugs? A this notebook throws a bunch or errors.... (and it should!)

@martinvonk
Copy link
Contributor Author

martinvonk commented Feb 2, 2026

How do you run a test on notebooks7_bugs? A this notebook throws a bunch or errors.... (and it should!)

In pytest you can run something and check if errors are raises with:

with pytest.raises(Exception):
    run_bugs_notebook()

and then the tests pass only if an Exception is raised.

@mbakker7 mbakker7 merged commit dd2dc72 into mbakker7:master Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants