rewrite Path to address multiple issues #587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cube707
added
python
Cube707
force-pushed
the
fix/path
branch
4 times, most recently
from
e6cd2b1 to
c9a03d0
Compare
Cube707
changed the title
instead of string literals, which would mean two places requried changing
Collaborator
Author
|
@aaronhendry this version should address both issues, would you care to test it and give your opinion? install via: pip install -U "git+https://github.com/magmax/python-inquirer@fix/path" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to close #585 and close #586 by reconsidering bigger parts of the
Pathquestion-type. Mainly the validation function needs a rewrite.