Skip to content

Don't set the pipeline param if the sprintf returns an empty value #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Don't set the pipeline param if the sprintf returns an empty value #962

wants to merge 1 commit into from

Conversation

flaper87
Copy link
Contributor

@flaper87 flaper87 commented Aug 13, 2020 •
edited
Loading

closes #961

@flaper87 flaper87 requested review from jsvd and andsel August 13, 2020 07:32
jsvd
jsvd reviewed Aug 13, 2020
View reviewed changes
Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should document this convention, can you add note in the pipeline setting documentation?

@flaper87 flaper87 requested a review from jsvd August 13, 2020 11:34
@flaper87
Copy link
Contributor Author

This was cherry-picked and pushed to the repo: 8804933

@flaper87 flaper87 closed this Aug 13, 2020
@flaper87 flaper87 deleted the issue/961 branch August 13, 2020 13:29
@jsvd
Copy link
Member

jsvd commented Aug 13, 2020

Thanks for the PR @flaper87, this has been released as v10.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andsel andsel Awaiting requested review from andsel

@jsvd jsvd Awaiting requested review from jsvd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pipeline value is sent to elasticsearch even when the value is an empty string
2 participants
@flaper87 @jsvd