Changed conditionally addition of type to open in case of _monitoring #900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbavey
reviewed
Nov 19, 2019
CHANGELOG.md
Outdated
| @@ -1,5 +1,8 @@ | |||
| ## 10.2.3 | |||
| - Fixed 8.x type removal compatibility issue to continue for monitoring endpoint from LogStash's X-Pack[#899](https://github.com/logstash-plugins/logstash-output-elasticsearch/pull/899) | |||
There was a problem hiding this comment.
I'm not sure this review comment accurately describes the change? I think the description given in #899 is more apt.
There was a problem hiding this comment.
Done, reworded a little bit. I hope it's not too long
robbavey
reviewed
Nov 19, 2019
CHANGELOG.md
Outdated
| @@ -1,5 +1,8 @@ | |||
| ## 10.2.3 | |||
| - After remove of type with [#892](https://github.com/logstash-plugins/logstash-output-elasticsearch/pull/892) LogStash X-Pack monitoring started to fail with NPE, (see LogStash #11312) the cause is the ES endpoint used to push monitoring data (\_monitoring/) that needed the type field. Extracted the logic to decide if the type must be removed or not in a separate method and extend the plugin in X-Pack redefining the same method. | |||
There was a problem hiding this comment.
I wonder if we could do something like:
Opened type removal logic for extension. This allows X-Pack Elasticsearch output to continue using types for special case `/_monitoring` bulk endpoint, enabling a fix for LogStash #11312. [#900](https://github.com/logstash-plugins/logstash-output-elasticsearch/pull/900)
elasticsearch-bot
pushed a commit
that referenced
this pull request
Nov 20, 2019
elasticsearch-bot
pushed a commit
that referenced
this pull request
Nov 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed conditionally addition of type to open in case of _monitoring endpoint
Related to LS #11312 and plugin issue #899