-
Notifications
You must be signed in to change notification settings - Fork 307
Add support for pipeline to decode from metadata target_ingest_pipeline #1113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kaisecheng
merged 11 commits into
logstash-plugins:main
from
kaisecheng:allow_metadata_pipeline
Feb 7, 2023
Merged
Add support for pipeline to decode from metadata target_ingest_pipeline #1113
kaisecheng
merged 11 commits into
logstash-plugins:main
from
kaisecheng:allow_metadata_pipeline
Feb 7, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st_pipeline]` Fixes: logstash-plugins#1112
…st_pipeline]` Fixes: logstash-plugins#1112
…ash-output-elasticsearch into allow_metadata_pipeline # Conflicts: # CHANGELOG.md # spec/unit/outputs/elasticsearch_spec.rb
yaauie
reviewed
Jan 31, 2023
yaauie
reviewed
Jan 31, 2023
Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com>
Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com>
Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com>
Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com>
All test cases run successfully but one of the unit test stages is frozen after tests are done. |
…asticsearch into allow_metadata_pipeline # Conflicts: # CHANGELOG.md # logstash-output-elasticsearch.gemspec
yaauie
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks to work as-advertised. Unsure about the failing spec and can't trigger Travis builds for some reason, will attempt to replicate when I get home in a few hours.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1112
This PR allows
pipeline
option to take value from[@metadata][target_ingest_pipeline]
ifpipeline
is not set.if
[@metadata][target_ingest_pipeline]
gives empty string, thepipeline
won't be setThanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/