Skip to content

Add support for pipeline to decode from metadata target_ingest_pipeline #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 7, 2023

Conversation

kaisecheng
Copy link
Contributor

@kaisecheng kaisecheng commented Jan 31, 2023

Fixes: #1112

This PR allows pipeline option to take value from [@metadata][target_ingest_pipeline] if pipeline is not set.
if [@metadata][target_ingest_pipeline] gives empty string, the pipeline won't be set

Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/

…ash-output-elasticsearch into allow_metadata_pipeline

# Conflicts:
#	CHANGELOG.md
#	spec/unit/outputs/elasticsearch_spec.rb
@kaisecheng kaisecheng changed the title Add support for pipeline to be decode from metadata target_ingest_pipeline Add support for pipeline to decode from metadata target_ingest_pipeline Jan 31, 2023
kaisecheng and others added 5 commits January 31, 2023 21:56
Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com>
Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com>
Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com>
Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com>
@kaisecheng
Copy link
Contributor Author

All test cases run successfully but one of the unit test stages is frozen after tests are done.

@kaisecheng kaisecheng requested a review from yaauie February 1, 2023 13:10
…asticsearch into allow_metadata_pipeline

# Conflicts:
#	CHANGELOG.md
#	logstash-output-elasticsearch.gemspec
Copy link
Contributor

@yaauie yaauie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to work as-advertised. Unsure about the failing spec and can't trigger Travis builds for some reason, will attempt to replicate when I get home in a few hours.

@kaisecheng kaisecheng merged commit 397921d into logstash-plugins:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow events to directly encode the downstream pipeline to use.
3 participants