Skip to content

Fix referencing Gem classes from global lexical #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

andsel
Copy link
Contributor

@andsel andsel commented Oct 14, 2021

Some Gem classes was referenced from open Logstash lexical scope while it should refer from the global.

@andsel andsel force-pushed the fix/refer_global_scope branch from 1190b2b to 5d6f0bb Compare October 14, 2021 17:19
Copy link
Contributor

@yaauie yaauie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@yaauie yaauie merged commit f0b6a6a into logstash-plugins:master Oct 14, 2021
@andsel andsel added the bug label Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants