Skip to content

docs: remove noise from http_compression option #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 4, 2022

Conversation

yaauie
Copy link
Contributor

@yaauie yaauie commented Aug 10, 2021

The existing docs for http_compression (which controls whether requests are compressed) have a lot of noise about response decompression that is accurate but can be misleading.

This change removes the noise and states simply that http_compression can be enabled to ensure that requests are compressed, and that the plugin is capable of handling compressed responses independent of this setting.

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements! Thank you for making them. Left some suggestions inline for your consideration.

@andsel
Copy link
Contributor

andsel commented Jul 14, 2022

ping @yaauie to integrate the suggestions

yaauie and others added 2 commits October 4, 2022 20:40
include link to PR

Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
@yaauie yaauie merged commit f69df56 into logstash-plugins:main Oct 4, 2022
@yaauie yaauie deleted the http_compression-docs branch October 4, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants