Skip to content

Feat: always check ES license #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 19, 2021
Merged

Feat: always check ES license #1005

merged 7 commits into from
Apr 19, 2021

Conversation

kares
Copy link
Contributor

@kares kares commented Apr 7, 2021 •
edited
Loading

Historically the output did not do a license check on OSS Logstash.
However with the recent ES licensing change (since 7.11) there's no OSS ES artifact anymore.
Thus the distinction makes no sense.

see #1004

@kares kares marked this pull request as ready for review April 7, 2021 17:29
@kares kares requested a review from robbavey April 13, 2021 18:44
robbavey
robbavey approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM - providing @acchen97 and/or @roaksoax approve the change in deprecation warning text

roaksoax
roaksoax approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@roaksoax roaksoax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@roaksoax roaksoax self-requested a review April 14, 2021 13:09
roaksoax
roaksoax suggested changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@roaksoax roaksoax left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs to ensure we are sending data to licensed ES.

roaksoax
roaksoax approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@roaksoax roaksoax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kares kares merged commit 986d76f into logstash-plugins:master Apr 19, 2021
@wiardvanrij wiardvanrij mentioned this pull request May 31, 2021
Closed
@dblock dblock mentioned this pull request Jun 4, 2021
Closed
@mmguero mmguero mentioned this pull request Sep 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roaksoax roaksoax roaksoax approved these changes

@robbavey robbavey robbavey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kares @roaksoax @robbavey