Skip to content

Open type removal logic for change #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andsel opened this issue Nov 19, 2019 · 2 comments
Closed

Open type removal logic for change #899

andsel opened this issue Nov 19, 2019 · 2 comments
Assignees
@andsel

Comments

@andsel
Copy link
Contributor

andsel commented Nov 19, 2019 •
edited
Loading

After issue #892 to remove the type, LogStash X-Pack monitoring started to fail (see LogStash #11312) because the ES endpoint used to push monitoring data (_monitoring/) needs the type field, without type it fails with NPE. The solution is to move the logic to decide if the type must be removed or not, in a separate method and extend the plugin in X-Pack redefining the same method.
@andsel andsel self-assigned this Nov 19, 2019
@andsel andsel mentioned this issue Nov 19, 2019
Closed
@andsel
Copy link
Contributor Author

andsel commented Nov 19, 2019

PR that solved this is #900

@andsel andsel mentioned this issue Nov 19, 2019
Closed
@andsel
Copy link
Contributor Author

andsel commented Nov 20, 2019

closed by #900 and publication of v10.2.3

@andsel andsel closed this as completed Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andsel andsel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andsel