Skip to content

Continue to use .raw instead of .keyword #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
clintongormley opened this issue Aug 26, 2016 · 3 comments
Closed

Continue to use .raw instead of .keyword #466

clintongormley opened this issue Aug 26, 2016 · 3 comments
Assignees

Comments

@clintongormley
Copy link

Hi all

We discussed the issue of renaming .raw to .keyword fields in the Elasticsearch FixItFriday again today. I thought that field aliases (elastic/elasticsearch#17511) might possibly be a solution to help with the transition. We even considered adding a dedicated hack to automatically check for a .raw field if a .keyword field didn't exist.

Unfortunately we didn't come up with a good solution.

We're aware of the impact that this rename will have on our users and want to suggest that you reconsider the change in #462

In Elasticsearch, naming the field .keyword makes sense given our variety of use cases, but Logstash solves a much more focused problem. A .raw field HAS made sense in the past and will continue to make sense in Logstash's future. There's no real reason to change - I think it is OK to deviate from the Elasticsearch default here.

It's certainly an easy way of removing a large obstacle from the upgrade path.

/cc @tsg @monicasarbu

@monicasarbu
Copy link

Thanks for the heads up. I think this doesn't affect Beats, because we define the type of each exported field, so normally there is no .keyword created in Elasticsearch. We also didn't use .raw before.

@suyograo suyograo self-assigned this Aug 26, 2016
@monicasarbu
Copy link

This might affect Add-data UI. /cc @Bargs

suyograo added a commit to suyograo/logstash-output-elasticsearch that referenced this issue Sep 8, 2016
In PR logstash-plugins#462 (comment)
we used `.keyword` to match ES's change in default behavior.

Both approaches, using `.keyword` to match ES for consistency and using `.raw` to match
existing logstash data has pros/cons. I think at this time it is wise to err on the side of
easy-upgrade-path so reverting this back to using `.raw` as before

Fixes logstash-plugins#466
@suyograo
Copy link
Contributor

suyograo commented Sep 8, 2016

See #474 (comment), we are sticking to .keyword instead of .raw. This will not be a painful upgrade because we don't force update the template for existing users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants