Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: grantjenks/python-diskcache
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: knz/python-diskcache
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Apr 3, 2024

  1. Support sqlite builds with DQS=off 

    If sqlite3 is built with double-quoted string literals disabled (which
is recommended, see https://www.sqlite.org/compile.html#dqs),
diskcache starts failing with the following crypting error:

```
no such column: "size"
```

This is because the syntax `WHERE key = "size"` in standard SQL refers
to a column named "size", not a string literal. Parsing this as a
string literal is a conditional sqlite extension.

This patch makes the code more robust by avoiding this optional sqlite
feature.
    @knz
    knz committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    b89111d View commit details
    Browse the repository at this point in the history
Loading