refactor(app-check): migrate to TypeScript #8813
Open
+946
−687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mikehardy
reviewed
Dec 29, 2025
| /** | ||
| * Create a ReactNativeFirebaseAppCheckProvider option for use in react-native-firebase | ||
| */ | ||
| newReactNativeFirebaseAppCheckProvider(): ReactNativeFirebaseAppCheckProvider; |
Collaborator
There was a problem hiding this comment.
still can't believe they didn't take the opportunity to unify the interface and make it runtime dynamic on all platforms, requiring this shimming for any sort of reasonable interpreted language DX
mikehardy
reviewed
Dec 29, 2025
Collaborator
mikehardy
left a comment
mikehardy
left a comment
There was a problem hiding this comment.
not much to add except the same thoughts from the crashlytics PR
- can we ship all files necessary to run a build on this module from within node_modules ? would help make it locally patch-able and in my experience help drive future community contributions as a "drive-by" PR will be possible vs full repo fork setup
- can we extend a common tsconfig as it appears to be boilerplate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Release Summary
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter