Skip to content

[v12] feat(ui-checkbox): Checkbox rework#2392

Open
git-nandor wants to merge 1 commit intov12from
INSTUI-4788_checkbox_rework
Open

[v12] feat(ui-checkbox): Checkbox rework#2392
git-nandor wants to merge 1 commit intov12from
INSTUI-4788_checkbox_rework

Conversation

@git-nandor
Copy link
Contributor

@git-nandor git-nandor commented Feb 3, 2026

INSTUI-4788

Summary

Migrated Checkbox component from the old theming system.

Test plan

On the documentation page, verify that everything displays and works correctly.

Co-Authored-By: 🤖 Claude

@git-nandor git-nandor self-assigned this Feb 3, 2026
@git-nandor git-nandor force-pushed the INSTUI-4788_checkbox_rework branch from 72b8b5c to 3e9276a Compare February 3, 2026 09:15
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://instructure.design/pr-preview/pr-2392/

Built to branch gh-pages at 2026-02-12 18:44 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@git-nandor git-nandor requested a review from adamlobler February 3, 2026 09:19
@git-nandor git-nandor marked this pull request as ready for review February 3, 2026 09:19
@git-nandor git-nandor force-pushed the INSTUI-4788_checkbox_rework branch from 3e9276a to ff8c452 Compare February 3, 2026 10:53
@git-nandor git-nandor changed the title Inst UI 4788 checkbox rework feat(ui-checkbox): Checkbox rework Feb 3, 2026
@git-nandor git-nandor force-pushed the INSTUI-4788_checkbox_rework branch 6 times, most recently from bf8c42b to aee618d Compare February 10, 2026 17:58
@git-nandor git-nandor changed the title feat(ui-checkbox): Checkbox rework [v12] feat(ui-checkbox): Checkbox rework Feb 10, 2026
@git-nandor git-nandor force-pushed the INSTUI-4788_checkbox_rework branch 4 times, most recently from ac3cbb9 to 79805de Compare February 12, 2026 13:53
Comment on lines 283 to 285
(variant === 'toggle'
? styles?.indentedToggleError
: styles?.indentedError)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that these styles contain the left padding, but on the site unfortunately i can't see it:/

Image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on our discussion, I’ve added a custom calculation to determine the correct padding values.

@git-nandor git-nandor force-pushed the INSTUI-4788_checkbox_rework branch from 79805de to 9c79609 Compare February 12, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants