-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Add transformer cache context for SkyReels-V2 pipelines & Update docs #12837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transformer cache context for SkyReels-V2 pipelines & Update docs #12837
Conversation
… predictions for skyreels-v2 pipes.
| - [SkyReels-V2 I2V 14B - 720P](https://huggingface.co/Skywork/SkyReels-V2-I2V-14B-720P-Diffusers) | ||
| - [SkyReels-V2 FLF2V 1.3B - 540P](https://huggingface.co/Skywork/SkyReels-V2-FLF2V-1.3B-540P-Diffusers) | ||
|
|
||
| This model was contributed by [M. Tolga Cangöz](https://github.com/tolgacangoz). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the contributor of this model spending almost 2 months on its integration, I request that the mention be added.
Because SkyReels-V2/I wasn't mentioned in the 0.35.x releases at the new pipelines section.
I cannot understand why such a small PR has been waiting for 3 weeks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your contribution is included in the release notes under the "Significant community contributions" section. The highlights section at the top is reserved for a small number of the most impactful additions — not every merged PR is featured there, regardless of the effort involved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree with you that you evaluated the integration of SkyReels-V2 as not impactful enough. This model was the first open-source video generative model employing AutoRegressive Diffusion-Forcing architecture. And, Aryan's mentioning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The decision on what goes in the highlights section is at the maintainers' discretion and isn't something we debate on a per-PR basis. Your contribution is credited appropriately in the release notes.
I'm going to consider this discussion closed.
| - [SkyReels-V2 I2V 1.3B - 540P](https://huggingface.co/Skywork/SkyReels-V2-I2V-1.3B-540P-Diffusers) | ||
| - [SkyReels-V2 I2V 14B - 540P](https://huggingface.co/Skywork/SkyReels-V2-I2V-14B-540P-Diffusers) | ||
| - [SkyReels-V2 I2V 14B - 720P](https://huggingface.co/Skywork/SkyReels-V2-I2V-14B-720P-Diffusers) | ||
| - [SkyReels-V2 FLF2V 1.3B - 540P](https://huggingface.co/Skywork/SkyReels-V2-FLF2V-1.3B-540P-Diffusers) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FLF2V was producing bad results at the 1.3B model; I didn't even create its HF repo, but put it here as a placeholder at that time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds transformer cache context support to SkyReels-V2 pipelines to enable caching optimizations during inference. The cache contexts separate conditional and unconditional forward passes with "cond" and "uncond" labels respectively.
- Wraps transformer calls with
cache_context()for both conditional and unconditional predictions - Applies the pattern consistently across all five SkyReels-V2 pipeline variants
- Updates documentation with contributor credit (unrelated change)
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/diffusers/pipelines/skyreels_v2/pipeline_skyreels_v2_i2v.py |
Wraps conditional and unconditional transformer calls with cache_context("cond") and cache_context("uncond") |
src/diffusers/pipelines/skyreels_v2/pipeline_skyreels_v2_diffusion_forcing_v2v.py |
Wraps conditional and unconditional transformer calls with cache_context("cond") and cache_context("uncond") |
src/diffusers/pipelines/skyreels_v2/pipeline_skyreels_v2_diffusion_forcing_i2v.py |
Wraps conditional and unconditional transformer calls with cache_context("cond") and cache_context("uncond") |
src/diffusers/pipelines/skyreels_v2/pipeline_skyreels_v2_diffusion_forcing.py |
Wraps conditional and unconditional transformer calls with cache_context("cond") and cache_context("uncond") |
src/diffusers/pipelines/skyreels_v2/pipeline_skyreels_v2.py |
Wraps conditional and unconditional transformer calls with cache_context("cond") and cache_context("uncond") |
docs/source/en/api/pipelines/skyreels_v2.md |
Removes FLF2V model listing and adds contributor credit (unrelated to cache context changes) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yiyixuxu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This PR adds transformer cache context for SkyReels-V2 pipelines and & updates docs.