Fix CI workflows to use Node.js 24.11.1 and resolve type compatibility issues#3025
Fix CI workflows to use Node.js 24.11.1 and resolve type compatibility issues#3025Copilot wants to merge 4 commits intorenovate/node-24.xfrom
Conversation
|
|
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: mrlubos <12529395+mrlubos@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## renovate/node-24.x #3025 +/- ##
===================================================
Coverage 33.01% 33.01%
===================================================
Files 426 426
Lines 32792 32792
Branches 2126 2127 +1
===================================================
Hits 10827 10827
Misses 21937 21937
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@copilot CI still failing |
The issue was that @types/node 24.x is incompatible with Node.js 20.x and 22.x in the CI matrix. Using @types/node 20.x ensures compatibility across all tested Node.js versions (20.19.0, 22.12.0, and 24.11.1). Co-authored-by: mrlubos <12529395+mrlubos@users.noreply.github.com>
Fixed! The CI was failing due to type incompatibilities caused by @types/node 24.x being incompatible with Node.js 20.x and 22.x. I've downgraded @types/node to v20.19.25 to ensure compatibility across all Node.js versions in the CI matrix (20.19.0, 22.12.0, and 24.11.1), and regenerated the pnpm-lock.yaml to resolve the conflicts. (commit 83b50d9) |
88be39d to
8701f5a
Compare
389b739 to
797be90
Compare
c1cd2c5 to
51e3988
Compare
25a1d12 to
ffe08c8
Compare
f413392 to
4f1a11b
Compare
33cc397 to
b61ec95
Compare
9117e10 to
87fcf65
Compare
The renovate bot updated
.nvmrcto Node.js 24.11.1 but left workflow files referencing 24.10.0, causing CI failures. Additionally, the update to @types/node 24.x caused type incompatibilities with the CI matrix that tests against Node.js 20.x and 22.x.Changes
node-versionmatrix in.github/workflows/ci.ymlfrom24.10.0to24.11.1matrix.node-version == '24.10.0') to use24.11.1in ci.ymlnode-versionin.github/workflows/coverage.ymlto24.11.1node-versionin.github/workflows/release.ymlto24.11.1@types/nodefrom24.10.1to20.19.25to ensure type compatibility across all Node.js versions tested in CI (20.19.0, 22.12.0, and 24.11.1)pnpm-lock.yamlto resolve type conflicts caused by mixed @types/node versionsAll workflow files now align with the Node.js version specified in
.nvmrc, and type checking passes successfully across all tested Node.js versions.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.