Repository navigation
fix: CTORNDSD-679: WebComponents migration - #29
Merged
Merged
Conversation
…r story generation - Move component descriptions from individual story files to native-story transformer - Add React-to-web-component terminology replacements (children→slot, props→properties, etc.) - Remove manual loader-examples.ts in favor of generated fixture stories - Remove three custom Loader story variants (LoaderSectionVariant, SectionLoaderButtonVariant, InlineLoaderButtonVariant) - Refactor gd-loader to use theme-driven animation token resolution instead of hardcoded keyframe names - Add tests for custom animation token support and keyframe generation - Update generate-story-fixtures script to eliminate special Loader handling - Consolidate parameters.docs.description.component references to sourceMeta.parameters - Reorder Button stories (Default before AllVariants) to match React parity
…riants - Add `legacyRouteAliases` mapping retired Loader story IDs to canonical default scene - Extend `legacyRedirect()` to resolve aliases before checking shared/scoped routes - Extract `keyframesCssBlockToText()` helper for serializing animation token keyframes - Refactor gd-skeleton and gd-loader to use extracted keyframes helper - Add tests for alias redirection and custom animation token rendering - Update link validation to respect legacy route aliases - Set default args for Button stories (children, variant) for React/WC parity
…attribute - Add `color` prop to gd-label for custom text color styling - Add `ariaLabel` prop to gd-label for accessibility - Reflect `isLoading` attribute on gd-button for proper HTML representation - Update react-parity.json to track new Label properties - Add tests for color/ariaLabel mapping and isLoading reflection - Update Storybook arg types and helpers for new properties - Enhance Button isLoading with description and control metadata - Fix React storybook metadata capture to support 'React/' prefix in titles
Zlodej43sm
marked this pull request as ready for review
October 8, 2026 08:45
- Add custom CSS to normalize root collapse button font styling - Apply font-size: 14px, font-weight: 700, and remove text-transform - Inject styles via managerHead configuration
rcasian
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebComponents migration