Skip to content

๐Ÿ› ๏ธ Refactor: no casting Vue instances as anyย #80

Open

Description

@dlqqq

Motivation ๐Ÿ

It's bad practice to cast types as any just to circumvent TS compiler errors; that kind of defeats the purpose of type-checking if we disable its functionality every time we run into a problem. i read this article here:

https://v3.vuejs.org/guide/typescript-support.html#using-with-options-api

which talks about how the TS compiler has difficulty inferring types in the Vue framework. Explicitly specifying them with an interface is the preferred method of resolution.

Originally posted by @diracs-delta in #79 (comment)

Describe your refactoring solution ๐Ÿ› ๏ธ

  • identify all instances of Vue instances being cast as any to circumvent TS compiler errors
  • add strict checks to tsconfig.json that disable casts to any

Activity

  1. added
    Domain: Dev ExperienceThis issue pertains to a developer's emotions and attitudes when building Grey Software.
    Role: Software EngineerUses technology to design, develop, test, and maintain creative software solutions.
    on Oct 28, 2020
  2. dlqqq commented on Oct 28, 2020

    @dlqqq
    ContributorAuthor

    TS doesn't actually having a compiler option disabling explicit casts to any. we'll just have to wait until we implement ESlint

    https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-explicit-any.md

  3. self-assigned this
    on Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Domain: Dev ExperienceThis issue pertains to a developer's emotions and attitudes when building Grey Software.Role: Software EngineerUses technology to design, develop, test, and maintain creative software solutions.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions