Repository navigation
FIX: subscription returns incorrect result when data loader is used during fields resolving. - #287
Closed
DayS1eeper wants to merge 1 commit into
Closed
DayS1eeper wants to merge 1 commit into
DayS1eeper wants to merge 1 commit into
Conversation
…uring fields resolving.
Author
|
@syrusakbary Could you please take a look at this? |
|
@DayS1eeper this is legacy repo, with the last commit more than 1 year ago. Probably you need https://github.com/graphql-python/graphql-core |
Author
|
@TitanFighter I use graphql-core 2.3.2 and graphene 2.1.9 in my project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes batching for subscriptions.
Without this fix
batch_load_fnis called after everyloadcall andtest_batches_subscription_resultfails onbecause
subscription_results[0].datacontains