Conversation
ListTasks ranged a map and then sliced it. Each call walks the map in a new order, so a later page can repeat names from an earlier page and drop others. Sort by atespace and name before applying offset and limit.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
MemoryStore.ListTasksbuilds its slice by ranging a Go map, then appliesoffset/limit. Map iteration order is randomized on every call, so two pages are not slices of the same sequence.With 8 tasks and a page size of 4, the first call returned
task-01and the next page returnedtask-01again. Tasks that sort into the other page are dropped. Redis listing is ordered by index score, so this only affects the in-memory store used for tests and single-node setups.Fix
Sort the filtered tasks by atespace, then name, before slicing. Stored records are not modified.
Verification
Before the sort,
go test ./internal/store/memory -run TestListTasksPagesDoNotOverlap -count=1failed:After the sort,
go test ./internal/store/memory -count=1passes.